NotificationsYou must be signed in to change notification settings
Fork9.4k
Star12k

Fix incorrect free_shipping flag for virtual products#40193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

gexxx05 wants to merge1 commit intomagento:2.4-develop

base:2.4-develop

Choose a base branch

fromgexxx05:fix-free-shipping-flag

Open

Fix incorrect free_shipping flag for virtual products#40193

gexxx05 wants to merge1 commit intomagento:2.4-developfromgexxx05:fix-free-shipping-flag

Conversation

Copy link

gexxx05 commentedSep 16, 2025

This fixes the incorrect free_shipping flag for virtual products described in#40184

Description (*)

The fix resets the billing address free_shipping flag in the same way it is done for the shipping address.

Fixed Issues (if relevant)

FixesIncorrect free_shipping flag for virtual products #40184

Manual testing scenarios (*)

Go through steps to reproduce from issue, on step 8 the free_shipping flag for item test2 is 1 after adding this fix.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)

Fix incorrect free_shipping flag for virtual products

429b340

Copy link

m2-assistantbot commentedSep 16, 2025

Hi@gexxx05. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example:@magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the buildshere
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review theCode Contributions documentation.
JoinMagento Community Engineering Slack and ask your questions in#github channel.