Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit0d99370

Browse files
committed
Fix StoreCatalogInheritance1 to use 32bit inhseqno
For no apparent reason, this function was using a 16bit-wide inhseqnovalue, rather than the correct 32 bit width which is what is stored inthe pg_inherits catalog. This becomes evident if you try to create atable with more than 65535 parents, because this error appears:ERROR: duplicate key value violates unique constraint «pg_inherits_relid_seqno_index»DETAIL: Key (inhrelid, inhseqno)=(329371, 0) already exists.Needless to say, having so many parents is an uncommon situations, whichexplains why this error has never been reported despite being havingbeen introduced with the Postgres95 1.01 sources in commitd31084e:https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/creatinh.c;hb=d31084e9d111#l349Backpatch all the way back.David Rowley noticed this while reviewing a patch of mine.Discussion:https://postgr.es/m/CAKJS1f8Dn7swSEhOWwzZzssW7747YB=2Hi+T7uGud40dur69-g@mail.gmail.com
1 parent31635bc commit0d99370

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/backend/commands/tablecmds.c‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ static void MergeAttributesIntoExisting(Relation child_rel, Relation parent_rel)
277277
staticvoidMergeConstraintsIntoExisting(Relationchild_rel,Relationparent_rel);
278278
staticvoidStoreCatalogInheritance(OidrelationId,List*supers);
279279
staticvoidStoreCatalogInheritance1(OidrelationId,OidparentOid,
280-
int16seqNumber,RelationinhRelation);
280+
int32seqNumber,RelationinhRelation);
281281
staticintfindAttrByName(constchar*attributeName,List*schema);
282282
staticvoidAlterIndexNamespaces(RelationclassRel,Relationrel,
283283
OidoldNspOid,OidnewNspOid,ObjectAddresses*objsMoved);
@@ -1969,7 +1969,7 @@ static void
19691969
StoreCatalogInheritance(OidrelationId,List*supers)
19701970
{
19711971
Relationrelation;
1972-
int16seqNumber;
1972+
int32seqNumber;
19731973
ListCell*entry;
19741974

19751975
/*
@@ -2009,7 +2009,7 @@ StoreCatalogInheritance(Oid relationId, List *supers)
20092009
*/
20102010
staticvoid
20112011
StoreCatalogInheritance1(OidrelationId,OidparentOid,
2012-
int16seqNumber,RelationinhRelation)
2012+
int32seqNumber,RelationinhRelation)
20132013
{
20142014
TupleDescdesc=RelationGetDescr(inhRelation);
20152015
Datumvalues[Natts_pg_inherits];
@@ -2023,7 +2023,7 @@ StoreCatalogInheritance1(Oid relationId, Oid parentOid,
20232023
*/
20242024
values[Anum_pg_inherits_inhrelid-1]=ObjectIdGetDatum(relationId);
20252025
values[Anum_pg_inherits_inhparent-1]=ObjectIdGetDatum(parentOid);
2026-
values[Anum_pg_inherits_inhseqno-1]=Int16GetDatum(seqNumber);
2026+
values[Anum_pg_inherits_inhseqno-1]=Int32GetDatum(seqNumber);
20272027

20282028
memset(nulls,0,sizeof(nulls));
20292029

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp