Commitf43530b

authored

chore: address someclippy::pedantic warnings (fspoettel#55)

1 parent84208a6 commitf43530bCopy full SHA for f43530b

File tree

+21

-18

lines changed

+21

-18

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`usecrate::template::{all_days, run_multi::run_multi};`
`2`	`2`
`3`	`3`	`pubfnhandle(is_release:bool,is_timed:bool){`
`4`		`-run_multi(all_days().collect(), is_release, is_timed);`
	`4`	`+run_multi(&all_days().collect(), is_release, is_timed);`
`5`	`5`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -65,5 +65,5 @@ pub fn handle(day: Day) {`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`println!("---");`
`68`		-println!("🎄 Type `cargo solve {}` to run your solution.", day);
	`68`	+println!("🎄 Type `cargo solve {day}` to run your solution.");
`69`	`69`	`}`

Lines changed: 15 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,26 +7,29 @@ use crate::template::{all_days, readme_benchmarks, Day};`
`7`	`7`	`pubfnhandle(day:Option<Day>,recreate_all:bool){`
`8`	`8`	`let stored_timings =Timings::read_from_file();`
`9`	`9`
`10`		`-let days_to_run = day.map(\|day\|HashSet::from([day])).unwrap_or_else(\|\|{`
`11`		`-if recreate_all{`
`12`		`-all_days().collect()`
`13`		`-}else{`
`14`		-// when the `--all` flag is not set, filter out days that are fully benched.
`15`		`-all_days()`
`16`		`-.filter(\|day\| !stored_timings.is_day_complete(day))`
`17`		`-.collect()`
`18`		`-}`
`19`		`-});`
	`10`	`+let days_to_run = day.map_or_else(`
	`11`	`+ \|\|{`
	`12`	`+if recreate_all{`
	`13`	`+all_days().collect()`
	`14`	`+}else{`
	`15`	+// when the `--all` flag is not set, filter out days that are fully benched.
	`16`	`+all_days()`
	`17`	`+.filter(\|day\| !stored_timings.is_day_complete(*day))`
	`18`	`+.collect()`
	`19`	`+}`
	`20`	`+},`
	`21`	`+ \|day\|HashSet::from([day]),`
	`22`	`+);`
`20`	`23`
`21`		`-let timings =run_multi(days_to_run,true,true).unwrap();`
	`24`	`+let timings =run_multi(&days_to_run,true,true).unwrap();`
`22`	`25`
`23`	`26`	`let merged_timings = stored_timings.merge(&timings);`
`24`	`27`	`merged_timings.store_file().unwrap();`
`25`	`28`
`26`	`29`	`println!();`
`27`	`30`	`match readme_benchmarks::update(merged_timings){`
`28`	`31`	`Ok(()) =>{`
`29`		`-println!("Stored updated benchmarks.")`
	`32`	`+println!("Stored updated benchmarks.");`
`30`	`33`	`}`
`31`	`34`	`Err(_) =>{`
`32`	`35`	`eprintln!("Failed to store updated benchmarks.");`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ use super::{`
`7`	`7`	`timings::{Timing,Timings},`
`8`	`8`	`};`
`9`	`9`
`10`		`-pubfnrun_multi(days_to_run:HashSet<Day>,is_release:bool,is_timed:bool) ->Option<Timings>{`
	`10`	`+pubfnrun_multi(days_to_run:&HashSet<Day>,is_release:bool,is_timed:bool) ->Option<Timings>{`
`11`	`11`	`letmut timings:Vec<Timing> =Vec::with_capacity(days_to_run.len());`
`12`	`12`
`13`	`13`	`all_days().for_each(\|day\|{`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ impl Timings {`
`38`	`38`	`match s{`
`39`	`39`	`Ok(timings) => timings,`
`40`	`40`	`Err(e) =>{`
`41`		`-eprintln!("{}", e);`
	`41`	`+eprintln!("{e}");`
`42`	`42`	`Timings::default()`
`43`	`43`	`}`
`44`	`44`	`}`
`@@ -67,10 +67,10 @@ impl Timings {`
`67`	`67`	`self.data.iter().map(\|x\| x.total_nanos).sum::<f64>() /1_000_000_f64`
`68`	`68`	`}`
`69`	`69`
`70`		`-pubfnis_day_complete(&self,day:&Day) ->bool{`
	`70`	`+pubfnis_day_complete(&self,day:Day) ->bool{`
`71`	`71`	`self.data`
`72`	`72`	`.iter()`
`73`		`-.any(\|t\|&t.day == day && t.part_1.is_some() && t.part_2.is_some())`
	`73`	`+.any(\|t\| t.day == day && t.part_1.is_some() && t.part_2.is_some())`
`74`	`74`	`}`
`75`	`75`	`}`
`76`	`76`

Comments

(0)