Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork30
[Refactor]: Always use % for getting intrinsics#100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
% for getting intrinsics% for getting intrinsics61c4ead to945e629CompareWhat's the benefit here? If everything in this package uses |
There is in the test files. |
True. What's the benefit of this change tho? |
ExE-Boss commentedJun 4, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The benefit is consistency and making it possible to deprecate the non‑ |
I'm not sure why we'd want to deprecate it? callBound is the newest helper, and I intentionally left off the |
codecovbot commentedJun 13, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #100 +/- ##==========================================- Coverage 91.03% 91.01% -0.02%========================================== Files 647 647 Lines 8931 9031 +100 Branches 2109 2150 +41 ==========================================+ Hits 8130 8220 +90- Misses 801 811 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Depending on the progression ofhttps://github.com/ljharb/proposal-get-intrinsic - in which I'm planning tonot require the |
No description provided.