Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Refactor]: Always use % for getting intrinsics#100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
ExE-Boss wants to merge1 commit intoljharb:main
base:main
Choose a base branch
Loading
fromExE-Boss:fix/always-use-percent-for-intrinsics

Conversation

@ExE-Boss
Copy link
Contributor

No description provided.

@ExE-BossExE-Boss changed the title[Fix]: Always use % for getting intrinsics[Refactor]: Always use % for getting intrinsicsMay 31, 2020
@ExE-BossExE-Bossforce-pushed thefix/always-use-percent-for-intrinsics branch from61c4ead to945e629CompareMay 31, 2020 11:31
@ljharb
Copy link
Owner

What's the benefit here? If everything in this package uses% bookends, then there's nothing testing "not using %".

@ExE-Boss
Copy link
ContributorAuthor

There is in the test files.

@ljharb
Copy link
Owner

True. What's the benefit of this change tho?

@ExE-Boss
Copy link
ContributorAuthor

ExE-Boss commentedJun 4, 2020
edited
Loading

The benefit is consistency and making it possible to deprecate the non‑% form.

@ljharb
Copy link
Owner

I'm not sure why we'd want to deprecate it? callBound is the newest helper, and I intentionally left off the% for it.

@codecov
Copy link

codecovbot commentedJun 13, 2020
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (8a9cf6a) to head (945e629).
⚠️ Report is 630 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main     #100      +/-   ##==========================================- Coverage   91.03%   91.01%   -0.02%==========================================  Files         647      647                Lines        8931     9031     +100       Branches     2109     2150      +41     ==========================================+ Hits         8130     8220      +90- Misses        801      811      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ljharb
Copy link
Owner

Depending on the progression ofhttps://github.com/ljharb/proposal-get-intrinsic - in which I'm planning tonot require the% - I'll be happy to rebase and land this PR once the proposal advances far enough.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ExE-Boss@ljharb

[8]ページ先頭

©2009-2025 Movatter.jp