- Notifications
You must be signed in to change notification settings - Fork1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Remove unusedmount() arguments from Livewire directive#9194
Open
AJenbo wants to merge1 commit intolivewire:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This is for backwards compatibility I believe! |
In that case can we instead add the 2 unused arguments to the mount method? |
@calebporzio since you are the author of3d47803 could you look at this? |
mount() arguments from Livewire directiveSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The
mount()method inLivewireManageris defined with 3 parameters:livewire/src/LivewireManager.php
Line 71 in509f225
However, the generated code calls this method with
5 arguments, which causes PHPStan to report a mismatch. Since the method signature doesn't account for the extra arguments, static analysis sees it as an incorrect method call—even though those extra arguments are unused.This shows up when analyzing Blade templates and can be confusing or noisy for users relying on stricter static analysis levels.
The solution
This PR removes the extra, unused arguments passed to
mount(), aligning the call with the method’s actual signature. This eliminates unnecessary static analysis warnings without changing any runtime behavior.The conversation
If the extra arguments are included intentionally—for example, to support future use cases or give extended components access to more context—an alternative would be to add the extra parameters to the
mount()method signature instead. That would preserve compatibility and still satisfy static analysis tools.I'm open to whichever approach makes the most sense long-term!