Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(deps-dev): bump org.spockframework:spock-core from 2.3-groovy-4.0 to 2.4-groovy-5.0 in the test-deps group#7467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dependabot wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromdependabot-maven-test-deps-4814d06dba

Conversation

@dependabot
Copy link
Contributor

@dependabotdependabotbot commented on behalf ofgithubDec 12, 2025
edited
Loading

Bumps the test-deps group with 1 update:org.spockframework:spock-core.

Updatesorg.spockframework:spock-core from 2.3-groovy-4.0 to 2.4-groovy-5.0

Release notes

Sourced fromorg.spockframework:spock-core's releases.

Spock 2.4

https://spockframework.org/spock/docs/2.4/release_notes.html

Spock 2.4-M7

https://spockframework.org/spock/docs/2.4-M7/index.html

Spock 2.4-M6

https://spockframework.org/spock/docs/2.4-M6/index.html

Spock 2.4-M5

https://spockframework.org/spock/docs/2.4-M5/index.html

Spock 2.4-M4

https://spockframework.org/spock/docs/2.4-M4/index.html

Spock 2.4-M3

https://spockframework.org/spock/docs/2.4-M3/index.html

Spock 2.4-M2

https://spockframework.org/spock/docs/2.4-M2/release_notes.html

Spock 2.4-M1

https://spockframework.org/spock/docs/2.4-M1/release_notes.html

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting@dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the test-deps group with 1 update: [org.spockframework:spock-core](https://github.com/spockframework/spock).Updates `org.spockframework:spock-core` from 2.3-groovy-4.0 to 2.4-groovy-5.0- [Release notes](https://github.com/spockframework/spock/releases)- [Changelog](https://github.com/spockframework/spock/blob/master/docs/release_notes.adoc)- [Commits](https://github.com/spockframework/spock/commits)---updated-dependencies:- dependency-name: org.spockframework:spock-core  dependency-version: 2.4-groovy-5.0  dependency-type: direct:development  dependency-group: test-deps...Signed-off-by: dependabot[bot] <support@github.com>
@coderabbitai
Copy link

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.


Comment@coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link

claudebot commentedDec 12, 2025
edited
Loading

Claude finished@dependabot[bot]'s task in 1m 10s ——View job


Review Complete

Todo List:

  • Check CI status
  • Review pom.xml changes
  • Verify compatibility concerns
  • Provide review feedback

Critical Issue Found

Groovy Version Mismatch: This PR upgrades Spock from2.3-groovy-4.0 to2.4-groovy-5.0, but the project still uses Groovy 4.0.28 (pom.xml:77). Spock's-groovy-X.Y suffix indicates the required Groovy major version - this will cause runtime compatibility issues.

Recommendation: Either:

  • Usespock-core:2.4-groovy-4.0 instead (maintains compatibility with current Groovy 4.0.28), or
  • Upgradegroovy.version to 5.x (requires broader compatibility testing across 12 Spock test files)

The CI tests may fail or produce unexpected behavior due to this version mismatch.

<junit-jupiter.version>6.0.1</junit-jupiter.version>
<groovy.version>4.0.28</groovy.version>
<spock.version>2.3-groovy-4.0</spock.version>
<spock.version>2.4-groovy-5.0</spock.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Critical Compatibility Issue: This upgrade bumps Spock fromgroovy-4.0 togroovy-5.0, but the project still uses Groovy 4.0.28 (line 77). Spock 2.4-groovy-5.0 requires Groovy 5.x, not 4.x, which will cause runtime compatibility issues. Either:

  1. Usespock-core:2.4-groovy-4.0 to match the current Groovy version, or
  2. Upgradegroovy.version to 5.x (which may require additional compatibility testing)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments

@filipelautertfilipelautertAwaiting requested review from filipelautertfilipelautert is a code owner

@wwillard7800wwillard7800Awaiting requested review from wwillard7800wwillard7800 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants


[8]ページ先頭

©2009-2025 Movatter.jp