Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(deps): bump groovy.version from 4.0.28 to 5.0.3#7458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
dependabot wants to merge1 commit intomaster
base:master
Choose a base branch
Loading
fromdependabot-maven-groovy.version-5.0.3

Conversation

@dependabot
Copy link
Contributor

@dependabotdependabotbot commented on behalf ofgithubDec 4, 2025•
edited
Loading

Bumpsgroovy.version from 4.0.28 to 5.0.3.
Updatesorg.apache.groovy:groovy-bom from 4.0.28 to 5.0.3

Commits

Updatesorg.apache.groovy:groovy-all from 4.0.28 to 5.0.3

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting@dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@coderabbitai
Copy link

coderabbitaibot commentedDec 4, 2025•
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Comment@coderabbitai help to get the list of available commands and usage tips.

@claude
Copy link

claudebot commentedDec 4, 2025•
edited
Loading

Claude finished@dependabot[bot]'s task ——View job

Review Complete

Todo List:

  • Read the changed file (pom.xml)
  • Check PR diff to see exact changes
  • Search for Groovy usage in codebase
  • Assess impact of major version upgrade (4.x → 5.x)
  • Check CI status
  • Provide review feedback

Review Summary

This PR upgrades Groovy from 4.0.28 to 5.0.3 (major version bump). Key finding:

Critical Issue:

  • Spock compatibility mismatch (pom.xml:78): The Spock version is still2.3-groovy-4.0, which targets Groovy 4.0. This may cause test failures with Groovy 5.x. The Spock version should be updated to a variant that supports Groovy 5.0.

Recommendation: Wait for CI test results. If tests fail, updatespock.version to a Groovy 5-compatible version before merging.

<junit-jupiter.version>6.0.1</junit-jupiter.version>
<groovy.version>4.0.28</groovy.version>
<groovy.version>5.0.3</groovy.version>
<spock.version>2.3-groovy-4.0</spock.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Potential compatibility issue: Groovy is being upgraded to 5.0.3, but Spock version is still2.3-groovy-4.0. This Spock version targets Groovy 4.0, which may not be compatible with Groovy 5.x. Consider updating tospock-core:2.4-M4-groovy-4.0 or a version that explicitly supports Groovy 5.0 if available.

@claude
Copy link

claudebot commentedDec 9, 2025•
edited
Loading

Claude finished@dependabot[bot]'s task ——View job

Review Summary

This PR upgrades Groovy from 4.0.28 to 5.0.3 (major version bump).

Todo List:

  • Check PR diff for changes
  • Read pom.xml to verify current state
  • Check CI status
  • Verify Spock compatibility issue status
  • Provide review feedback

Critical Issue Found

Spock version incompatibility (pom.xml:78): Groovy is upgraded to 5.0.3, butspock.version remains2.3-groovy-4.0, which targets Groovy 4.0 and is incompatible with Groovy 5.x.

Recommendation

Monitor running CI tests (Unit and Integration Tests currently in progress). If tests fail, updatespock.version to a Groovy 5-compatible variant before merging.

Bumps `groovy.version` from 4.0.28 to 5.0.3.Updates `org.apache.groovy:groovy-bom` from 4.0.28 to 5.0.3- [Commits](https://github.com/apache/groovy/commits)Updates `org.apache.groovy:groovy-all` from 4.0.28 to 5.0.3- [Commits](https://github.com/apache/groovy/commits)---updated-dependencies:- dependency-name: org.apache.groovy:groovy-bom  dependency-version: 5.0.3  dependency-type: direct:production  update-type: version-update:semver-major- dependency-name: org.apache.groovy:groovy-all  dependency-version: 5.0.3  dependency-type: direct:development  update-type: version-update:semver-major...Signed-off-by: dependabot[bot] <support@github.com>
@dependabotdependabotbotforce-pushed thedependabot-maven-groovy.version-5.0.3 branch from0886fa6 to9349000CompareDecember 9, 2025 14:00
<junit-jupiter.version>6.0.1</junit-jupiter.version>
<groovy.version>4.0.28</groovy.version>
<groovy.version>5.0.3</groovy.version>
<spock.version>2.3-groovy-4.0</spock.version>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Spock version2.3-groovy-4.0 targets Groovy 4.0 and is incompatible with Groovy 5.0.3.

@claude
Copy link

claudebot commentedDec 9, 2025•
edited
Loading

Claude finished@dependabot[bot]'s task ——View job

Todo List:

  • Check current PR diff
  • Read pom.xml to verify state
  • Check CI status
  • Provide final review

Review Summary

Issue persists: Groovy upgraded to 5.0.3 but Spock remains at 2.3-groovy-4.0 (incompatible).

CI Status: Unit and Integration Tests currently running - monitoring for Spock-related failures.

Previous inline comment still valid (pom.xml:78).

@MalloD12
Copy link
Collaborator

Fix Core build and test, apply the same to secure.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@claudeclaude[bot]claude[bot] left review comments

@filipelautertfilipelautertAwaiting requested review from filipelautertfilipelautert is a code owner

@wwillard7800wwillard7800Awaiting requested review from wwillard7800wwillard7800 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

Status: Active

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MalloD12
[8]ページ先頭
©2009-2025 Movatter.jp