Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

POC for parallel state#373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
adammitchelldev wants to merge3 commits intolimbonaut:master
base:master
Choose a base branch
Loading
fromadammitchelldev:add-parallel-state

Conversation

@adammitchelldev
Copy link

@adammitchelldevadammitchelldev commentedOct 6, 2025•
edited
Loading

We discussed aLimboParallelState approach on Discord that would implement#129

Here is a proof of concept, looking for suggestions and feedback.

  • The repetition of the loop code over children feels somewhat inelegant.
  • I'm not sure about the event consuming behaviour, right now if one child state consumes then the ParallelState itself will not get a dispatch, which seemed sensible.
  • There's no solution to the get_leaf_node problem yet, we just return the parallel state itself. (We talked about deprecating that and replacing with a get_leaf_nodes func.)
  • There are no tests.
  • The parallel state does not have a custom icon.

limbonaut reacted with heart emoji
@adammitchelldev
Copy link
Author

Fixes#129

@limbonaut
Copy link
Owner

Let's see if it builds in CI. We can also provide an icon for this node :)
It will take me a bit to review it, quite a busy week.

@limbonaut
Copy link
Owner

Nice implementation! I think it's good as it is, just needs some tests. Can you add tests for this class? They can be added to the hsm test suite, or in a separate file.

We’ll add an icon in a follow-up. Theget_leaf_states() function can also be introduced later, it doesn’t need to be included here.

@limbonaut
Copy link
Owner

I'm not sure about the event consuming behaviour, right now if one child state consumes then the ParallelState itself will not get a dispatch, which seemed sensible.

This is aligned well with how HSM does it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adammitchelldev@limbonaut
[8]ページ先頭
©2009-2025 Movatter.jp