Commit27e19eb

committed

#2 fixed guess style call with empty string

1 parent96617f8 commit27e19ebCopy full SHA for 27e19eb

File tree

+20

-4

lines changed

+20

-4

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,7 @@ create_test(DEFAULT extension change_overlap)`
`91`	`91`	`create_test(DEFAULT extension change_overlap_long)`
`92`	`92`	`create_test(DEFAULT extension change_hidden_file)`
`93`	`93`	`create_test(DEFAULT extension change_with_trailing_slash)`
	`94`	`+create_test(DEFAULT guess empty_string)`
`94`	`95`	`create_test(DEFAULT guess windows_root)`
`95`	`96`	`create_test(DEFAULT guess unix_root)`
`96`	`97`	`create_test(DEFAULT guess windows_separator)`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,4 +39,4 @@ <h1>{{ page.title }}</h1>`
`39`	`39`	`<footer>`
`40`	`40`	`find this repository on<ahref="https://github.com/likle/cwalk/tree/master">github</a>`
`41`	`41`	`</footer>`
`42`		`-</html>`
	`42`	`+</html>`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -74,4 +74,5 @@ WINDOWS.`
`74`	`74`
`75`	`75`	`\| Version\| Description\|`
`76`	`76`	`\|------------\|--------------------------------------------------------\|`
`77`		`-\|v1.2.0\| The function is introduced.\|`
	`77`	`+\|v1.2.1\| Fixed crash on call with empty string.\|`
	`78`	`+\|v1.2.0\| The function is introduced.\|`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1383,7 +1383,12 @@ enum cwk_path_style cwk_path_guess_style(const char *path)`
`1383`	`1383`	`// actually must be the first one), and determine whether the segment starts`
`1384`	`1384`	`// with a dot. A dot is a hidden folder or file in the UNIX world, in that`
`1385`	`1385`	`// case we assume the path to have UNIX style.`
`1386`		`-cwk_path_get_last_segment(path,&segment);`
	`1386`	`+if (!cwk_path_get_last_segment(path,&segment)) {`
	`1387`	`+// We couldn't find any segments, so we default to a UNIX path style since`
	`1388`	`+// there is no way to make any assumptions.`
	`1389`	`+returnCWK_STYLE_UNIX;`
	`1390`	`+ }`
	`1391`	`+`
`1387`	`1392`	`if (*segment.begin=='.') {`
`1388`	`1393`	`returnCWK_STYLE_UNIX;`
`1389`	`1394`	`}`

Lines changed: 10 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,15 @@`
`1`	`1`	`#include<cwalk.h>`
`2`	`2`	`#include<stdlib.h>`
`3`	`3`
	`4`	`+intguess_empty_string()`
	`5`	`+{`
	`6`	`+if (cwk_path_guess_style("")!=CWK_STYLE_UNIX) {`
	`7`	`+returnEXIT_FAILURE;`
	`8`	`+ }`
	`9`	`+`
	`10`	`+returnEXIT_SUCCESS;`
	`11`	`+}`
	`12`	`+`
`4`	`13`	`intguess_unguessable()`
`5`	`14`	`{`
`6`	`15`	`if (cwk_path_guess_style("myfile")!=CWK_STYLE_UNIX) {`
`@@ -93,4 +102,4 @@ int guess_windows_root()`
`93`	`102`	`}`
`94`	`103`
`95`	`104`	`returnEXIT_SUCCESS;`
`96`		`-}`
	`105`	`+}`

Comments

(0)