- Notifications
You must be signed in to change notification settings - Fork2.5k
wayland: Remove the hack to unset limits before entering fullscreen#14039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
e1df180 to940d919Compareslouken commentedOct 12, 2025
Should this go in for 3.4? |
Kontrabant commentedOct 12, 2025
It can't go in before the backported GNOME fixes are merged, or things will break for users on older versions. |
Kontrabant commentedOct 23, 2025
Just to note, the upstream changes are merged, and should ship in 48.7 later in November. |
3f84db6 to683041dCompareKontrabant commentedDec 2, 2025
Tagging this to go in early in the 3.6 cycle. The changes are upstream in GNOME, but they still need time to propagate and be backported where required, and I have some other windowing work that stacked nicely on top of this, regarding how windows with a min/max size and aspect are handled when the compositor demands that the window be a certain size, such as with maximized or tiled windows. |
Wayland is sometimes at-odds with clients that want to enforce an aspect ratio or min/max window size, as certain window states have dimensions that either must be obeyed (maximized), or will give terrible results if they aren't (tiled). Use viewports and/or a masking subsurface to handle cases where surfaces are unable to match the exact window size.The masking system also allows for switching the emulated fullscreen modes to aspect-correct by default, as it will handle masking non-native aspect ratios on compositors that don't automatically mask around fullscreen windows.
683041d tofeb5728Compare
The associated surface commit causes a warning (previously a crash) on GNOME + libdecor when clients enter fullscreen before the initial buffer commit.
This was only ever needed on GNOME, and is fixed in GNOME 49, but is waiting on upstream backports:https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4681 andhttps://gitlab.gnome.org/GNOME/mutter/-/merge_requests/4680
Fixes#14032