- Notifications
You must be signed in to change notification settings - Fork913
Simplify getting dirty files in repository#2004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
clyvari wants to merge2 commits intolibgit2:masterChoose a base branch fromclyvari:feat/is-dirty-detection-for-status-entry
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Simplify getting dirty files in repository#2004
clyvari wants to merge2 commits intolibgit2:masterfromclyvari:feat/is-dirty-detection-for-status-entry
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…logic to use StatusEntry.IsDirty
Add Unit Tests
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple PR to help getting the dirty files in the repository.
Background: When getting a
RepositoryStatus, we can use theIsDirtyproperty to tell if the repository is dirty.However, we don't have the same convenience to get the list of those dirty files.
Indeed, getting the actual list of dirty files would imply some duplicated logic in the client code, the same code that is present in the
RepositoryStatusctor to initialize theIsDirtyprop.What I propose is two parts (and 2 independent commits):
Most importantly, we move the
IsDirtydetection inside a StatusEntry, by adding a property of the same name. Before, the detection was done inside theRepositoryStatusctor, analyzing each StatusEntryFileStatus. Now each StatusEntry has the responsibility of telling whether it is dirty.Least importantly, but I think it's nice, we add a
Dirtycollection insideRepositoryStatus, that is initialized with all theIsDirtyStatusEntriesBefore thos changes, a client code working with dirty files could look like this:
With those two modifications, the client code would look like this:
I appreciate any feedback, let me know if anything need to be changed.