NotificationsYou must be signed in to change notification settings
Fork0
Star0

Commit48b128a

committed

refactor 653

1 parente9a3f0f commit48b128aCopy full SHA for 48b128a

File tree

2 files changed

-51

lines changed

src
- main/java/com/fishercoder/solutions
  - _653.java
- test/java/com/fishercoder
  - _653Test.java

2 files changed

-51

lines changed

`‎src/main/java/com/fishercoder/solutions/_653.java`

Lines changed: 1 addition & 36 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,9 @@`
`1`	`1`	`packagecom.fishercoder.solutions;`
`2`	`2`
`3`	`3`	`importcom.fishercoder.common.classes.TreeNode;`
`4`		`-importcom.fishercoder.common.utils.Notes;`
`5`	`4`
`6`	`5`	`importjava.util.ArrayList;`
`7`		`-importjava.util.HashMap;`
`8`	`6`	`importjava.util.List;`
`9`		`-importjava.util.Map;`
`10`	`7`
`11`	`8`	`/**`
`12`	`9`	`* 653. Two Sum IV - Input is a BST`
`@@ -39,7 +36,7 @@`
`39`	`36`	`*/`
`40`	`37`	`publicclass_653 {`
`41`	`38`
`42`		`-publicstaticclassListSolution {`
	`39`	`+publicstaticclassSolution1 {`
`43`	`40`	`publicbooleanfindTarget(TreeNoderoot,intk) {`
`44`	`41`	`if (root ==null) {`
`45`	`42`	`returnfalse;`
`@@ -66,36 +63,4 @@ private void dfs(TreeNode root, List<Integer> list) {`
`66`	`63`	`}`
`67`	`64`	`}`
`68`	`65`	`}`
`69`		`-`
`70`		`-@Notes(todo ="This solution fails by _653Test.test6(), need to fix it.")`
`71`		`-publicstaticclassMapSolution {`
`72`		`-publicbooleanfindTarget(TreeNoderoot,intk) {`
`73`		`-if (root ==null) {`
`74`		`-returnfalse;`
`75`		`- }`
`76`		`-Map<Integer,Integer>map =newHashMap();//value is index`
`77`		`-intindex =0;`
`78`		`-preorder(root,map,index);`
`79`		`-for (Map.Entry<Integer,Integer>entry :map.entrySet()) {`
`80`		`-if (map.containsKey(k -entry.getKey()) &&map.get(k -entry.getKey()) !=entry.getValue()) {`
`81`		`-returntrue;`
`82`		`- }`
`83`		`- }`
`84`		`-returnfalse;`
`85`		`- }`
`86`		`-`
`87`		`-privatevoidpreorder(TreeNoderoot,Map<Integer,Integer>map,intindex) {`
`88`		`-if (root ==null) {`
`89`		`-return;`
`90`		`- }`
`91`		`-map.put(root.val,index++);`
`92`		`-if (root.left !=null) {`
`93`		`-preorder(root.left,map, ++index);`
`94`		`- }`
`95`		`-if (root.right !=null) {`
`96`		`-preorder(root.right,map, ++index);`
`97`		`- }`
`98`		`- }`
`99`		`-`
`100`		`- }`
`101`	`66`	`}`

`‎src/test/java/com/fishercoder/_653Test.java`

Lines changed: 8 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,13 @@`
`13`	`13`	`importstaticjunit.framework.Assert.assertEquals;`
`14`	`14`
`15`	`15`	`publicclass_653Test {`
`16`		`-privatestatic_653.ListSolutionlistSolution;`
`17`		`-privatestatic_653.MapSolutionmapSolution;`
	`16`	`+privatestatic_653.Solution1solution1;`
`18`	`17`	`privatestaticbooleanexpected;`
`19`	`18`	`privatestaticTreeNoderoot;`
`20`	`19`
`21`	`20`	`@BeforeClass`
`22`	`21`	`publicstaticvoidsetup() {`
`23`		`-listSolution =new_653.ListSolution();`
`24`		`-mapSolution =new_653.MapSolution();`
	`22`	`+solution1 =new_653.Solution1();`
`25`	`23`	`}`
`26`	`24`
`27`	`25`	`@Before`
`@@ -33,24 +31,21 @@ public void setupForEachTest() {`
`33`	`31`	`publicvoidtest1() {`
`34`	`32`	`root =TreeUtils.constructBinaryTree(newArrayList<>(Arrays.asList(5,3,2,4,6,7)));`
`35`	`33`	`expected =true;`
`36`		`-assertEquals(expected,listSolution.findTarget(root,9));`
`37`		`-assertEquals(expected,mapSolution.findTarget(root,9));`
	`34`	`+assertEquals(expected,solution1.findTarget(root,9));`
`38`	`35`	`}`
`39`	`36`
`40`	`37`	`@Test`
`41`	`38`	`publicvoidtest2() {`
`42`	`39`	`root =TreeUtils.constructBinaryTree(newArrayList<>(Arrays.asList(2,1,3)));`
`43`	`40`	`expected =true;`
`44`		`-assertEquals(expected,listSolution.findTarget(root,4));`
`45`		`-assertEquals(expected,mapSolution.findTarget(root,4));`
	`41`	`+assertEquals(expected,solution1.findTarget(root,4));`
`46`	`42`	`}`
`47`	`43`
`48`	`44`	`@Test`
`49`	`45`	`publicvoidtest3() {`
`50`	`46`	`root =newTreeNode(1);`
`51`	`47`	`expected =false;`
`52`		`-assertEquals(expected,listSolution.findTarget(root,2));`
`53`		`-assertEquals(expected,mapSolution.findTarget(root,2));`
	`48`	`+assertEquals(expected,solution1.findTarget(root,2));`
`54`	`49`	`}`
`55`	`50`
`56`	`51`	`@Test`
`@@ -68,16 +63,14 @@ public void test4() {`
`68`	`63`
`69`	`64`	`root =TreeUtils.constructBinaryTree(newArrayList<>(Arrays.asList(2,0, -4,1,3)));`
`70`	`65`	`expected =true;`
`71`		`-assertEquals(expected,listSolution.findTarget(root, -1));`
`72`		`-assertEquals(expected,mapSolution.findTarget(root, -1));`
	`66`	`+assertEquals(expected,solution1.findTarget(root, -1));`
`73`	`67`	`}`
`74`	`68`
`75`	`69`	`@Test`
`76`	`70`	`publicvoidtest5() {`
`77`	`71`	`root =TreeUtils.constructBinaryTree(newArrayList<>(Arrays.asList(2,1,3, -4,0)));`
`78`	`72`	`expected =true;`
`79`		`-assertEquals(expected,listSolution.findTarget(root,2));`
`80`		`-assertEquals(expected,mapSolution.findTarget(root,2));`
	`73`	`+assertEquals(expected,solution1.findTarget(root,2));`
`81`	`74`	`}`
`82`	`75`
`83`	`76`	`@Test`
`@@ -93,7 +86,7 @@ public void test6() {`
`93`	`86`	`null,null,170,376,1421,1613,null,null,2534,null,`
`94`	`87`	`null,null,96,null,null,null,1303)));`
`95`	`88`	`expected =true;`
`96`		`-assertEquals(expected,listSolution.findTarget(root,5831));`
	`89`	`+assertEquals(expected,solution1.findTarget(root,5831));`
`97`	`90`	`// TreeUtils.printBinaryTree(root);`
`98`	`91`	`// assertEquals(expected, mapSolution.findTarget(root, 5831));`
`99`	`92`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit48b128a

File tree

2 files changed

2 files changed

`‎src/main/java/com/fishercoder/solutions/_653.java`

`‎src/test/java/com/fishercoder/_653Test.java`

0 commit comments