- Notifications
You must be signed in to change notification settings - Fork20.1k
fix(openai): filter function_call blocks in token counting#34396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
sujalmh wants to merge3 commits intolangchain-ai:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+7 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codspeed-hqbot commentedDec 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
CodSpeed Performance ReportMerging#34396 willnot alter performanceComparing Summary
Footnotes
|
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
fixFor PRs that implement a fix integrationPR made that is related to a provider partner package integration openai`langchain-openai` package issues & PRs
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Responses API returns messages with
function_callcontent blocks which causeget_num_tokens_from_messagesto raise aValueError: Unrecognized content block type.This occurs because the token counter internally uses the chat/completions format logic, which does not recognize these blocks.This PR updates
_format_message_contentto filter outfunction_callblocks when formatting messages for the chat/completions API (which includes the token counter). These blocks are redundant for token counting as the actual tool calls are already handled via the separatetool_callsfield, ensuring accurate counts without errors.Fixes#34378
Breaking Changes: None.