- Notifications
You must be signed in to change notification settings - Fork20.1k
fix: Issue #34139 - Explicitly disable callbacks in LLMToolSelectorMiddleware#34351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Manju080 wants to merge2 commits intolangchain-ai:masterChoose a base branch fromManju080:fix-tool-selector-disable-streaming
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
fix: Issue #34139 - Explicitly disable callbacks in LLMToolSelectorMiddleware#34351
Manju080 wants to merge2 commits intolangchain-ai:masterfromManju080:fix-tool-selector-disable-streaming
+38 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Author
Manju080 commentedDec 16, 2025
@sydney-runkle could you please look into this PR and let me know about any changes and updates. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#34139
When using
LLMToolSelectorMiddlewarewith stream_mode="messages", the internal tool selection tokens (the JSON output) are leaked into the final user stream. This happens because the internal LLM call inherits the parent's callback manager, which streams every token generated, even those intended only for middleware logic.This PR introduces a fix to prevent the leakage:
disable_streamingparameter to the middleware init (defaults toTrue) to give users control.False) which is not respected by all model providers (e.g ChatOllama still leaks callback events) this implementation passes config={"callbacks": []} to the internal invoke and ainvoke calls.I verified this locally using a reproduction script with ChatOllama (llama3.2).
Before: Output contained mixed internal JSON tokens
({"tools": ...}).After: Output is clean and contains only the final response tokens.