- Notifications
You must be signed in to change notification settings - Fork20.1k
fix: fix Fireworks' bind_tools(strict: bool) and reasoning_content #34341 #34342#34343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
DragosBobolea wants to merge3 commits intolangchain-ai:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+64 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…nd_toolsExtract strict from kwargs and pass it to convert_to_openai_tool when convertingtools. This ensures that when strict is provided, it's properly used during toolconversion and removed from kwargs before calling the parent bind method.Also extract reasoning_content from API responses and store it in additional_kwargsfor AIMessage objects.Add parametrized test to verify strict parameter handling.Add unit tests to verify reasoning_content extraction.
- Add noqa comment for FBT001 in parametrized test- Split long line in unit test to comply with line length limit
a8f171d to3f38a0cCompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
fireworks`langchain-fireworks` package issues & PRs fixFor PRs that implement a fix integrationPR made that is related to a provider partner package integration
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract strict from kwargs and pass it to convert_to_openai_tool when converting tools. This ensures that when strict is provided, it's properly used during tool conversion and removed from kwargs before calling the parent bind method.
Also extract reasoning_content from API responses and store it in additional_kwargs for AIMessage objects.
Fixes#34341 and#34342