- Notifications
You must be signed in to change notification settings - Fork178
Fix CLI credentials config file loading issue (closes #261)#685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ljluestc wants to merge1 commit intokubero-dev:mainChoose a base branch fromljluestc:fix/cli-credentials-issue-261
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
mms-gianni commentedAug 7, 2025
Wow. That's a great PR. I'll need some time to review it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
This pull request fixes issue#261 by resolving the Kubero CLI's failure to create the credentials configuration file during the
kubero logincommand, which caused subsequent commands likekubero dashboardandkubero listto fail with the error:Error while loading credentialsConfig file: Config File "credentials" Not Found in "[/etc/kubero /home/<user>/.kubero]". The changes ensure the credentials file is properly created in either/etc/kuberoor~/.kubero, validate the API URL to prevent errors likeunsupported protocol scheme "", and improve error handling for better user feedback.Motivation and Context:
The issue reported in#261 indicates that users successfully log in but cannot execute other CLI commands due to a missing credentials file. This disrupts the CLI's usability, particularly for users managing Kubero instances on separate machines from their Kubernetes cluster. The fix enhances the CLI's reliability by ensuring proper configuration file creation and validation, aligning with Kubero's goal of providing a seamless PaaS experience. The changes also address a dependency issue in the test suite to ensure CI/CD compliance.
Dependencies:
github.com/spf13/cobrafor CLI command handling (already part of Kubero’s dependencies).gopkg.in/yaml.v3for YAML parsing (already part of Kubero’s dependencies).sigs.k8s.io/controller-runtime@v0.17.2(to resolve test failure; see below).missing go.sum entry for github.com/evanphx/json-patch/v5), run:go.sumto include the required dependency, ensuringgo test ./...passes.Fixes#261
Type of change
How Has This Been Tested?
The changes were tested by:
cmd/kubero/login.go,cmd/kubero/main.go, andREADME.md.go build -o kubero ./cmd/kubero.kubero loginwith:julephttp://kubero.julep.ai<redacted>~/.kubero/credentialswas created with correct YAML content:kubero dashboardandkubero listto confirm they execute without errors.http://): Confirmed error message:invalid API URL./etc/kubero: Confirmed fallback to~/.kubero.credentials file not found; please run 'kubero login'.go get sigs.k8s.io/controller-runtime/pkg/client@v0.17.2to fixgo.sumerror.go test ./...in the repository root to confirm tests pass (cached tests forpkg/coreandpkg/dnspassed; no tests incmd/kuberooroperator/api/v1).Test Configuration:
<latest-commit>; update with actual hash when creating PR).Checklist:
go.sumissue)