- Notifications
You must be signed in to change notification settings - Fork3.4k
Update kube_config.py#2451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This issue occurs because parse_rfc3339 in the Kubernetes Python client does not guard against re.search() returning None. When the input string is not a valid RFC3339 timestamp, calling .groups() on None raises an AttributeError, which in kube_config.py is logged only as 'NoneType' object has no attribute 'groups' without showing the problematic string. This makes debugging difficult and allows execution to continue with an invalid expiry value. The fix is to update parse_rfc3339 to raise a clear ValueError when parsing fails and to improve logging in kube_config.py so the invalid string is included in the error message. This will provide clearer errors, prevent silent misconfigurations, and make the client more robust.
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow ourrelease note process to remove it. Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR isNOT APPROVED This pull-request has been approved by:sejalP07 The full list of commands accepted by this bot can be foundhere. Needs approval from an approver in each of these files: Approvers can indicate their approval by writing |
Welcome@sejalP07! |
Please sign the CLA |
This issue occurs because parse_rfc3339 in the Kubernetes Python client does not guard against re.search() returning None. When the input string is not a valid RFC3339 timestamp, calling .groups() on None raises an AttributeError, which in kube_config.py is logged only as 'NoneType' object has no attribute 'groups' without showing the problematic string. This makes debugging difficult and allows execution to continue with an invalid expiry value. The fix is to update parse_rfc3339 to raise a clear ValueError when parsing fails and to improve logging in kube_config.py so the invalid string is included in the error message. This will provide clearer errors, prevent silent misconfigurations, and make the client more robust.
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: