Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

kubelet: fix concurrent map write error when creating a pod with empty volume#135174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
carlory wants to merge1 commit intokubernetes:master
base:master
Choose a base branch
Loading
fromcarlory:fix-135089

Conversation

@carlory
Copy link
Member

@carlorycarlory commentedNov 6, 2025•
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

The supportsQuotasMap is being accessed with inconsistent locking:
Lines 68-69: The map and its lock are declared:

varsupportsQuotasMap=make(map[string]bool)
varsupportsQuotasLock sync.RWMutex

Lines 283-286, 303: In SupportsQuotas(), the map is accessed with supportsQuotasLock:

supportsQuotasLock.Lock()
defersupportsQuotasLock.Unlock()
ifsupportsQuotas,ok:=supportsQuotasMap[path];ok {
returnsupportsQuotas,nil

Lines 433, 470: In ClearQuota(), the map is modified without supportsQuotasLock (only quotaLock is held):

deferdelete(supportsQuotasMap,path)

delete(supportsQuotasMap,path)

Which issue(s) this PR is related to:

Fixes#135089
KEP:kubernetes/enhancements#1029

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubelet: fix concurrent map write error when creating a pod with empty volume when the LocalStorageCapacityIsolationFSQuotaMonitoring feature-gate is enabled

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

…y volumes when the LocalStorageCapacityIsolationFSQuotaMonitoring feature-gate is enabled
@k8s-ci-robotk8s-ci-robot added release-noteDenotes a PR that will be considered when it comes time to generate release notes. kind/bugCategorizes issue or PR as related to a bug. size/SDenotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. labelsNov 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying thetriage/accepted label and provide further guidance.

Thetriage/accepted label can be added by org members by writing/triage accepted in a comment.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@k8s-ci-robotk8s-ci-robot added needs-priorityIndicates a PR lacks a `priority/foo` label and requires one. sig/storageCategorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. labelsNov 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isNOT APPROVED

This pull-request has been approved by:carlory
Once this PR has been reviewed and has the lgtm label, please assignmsau42 for approval. For more information seethe Code Review Process.

The full list of commands accepted by this bot can be foundhere.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@carlory
Copy link
MemberAuthor

carlory commentedNov 6, 2025•
edited
Loading

/cc@RobertKrawitz@pacoxu
KEP Primary contact (assignee)

@k8s-ci-robot
Copy link
Contributor

@carlory: GitHub didn't allow me to request PR reviews from the following users: RobertKrawitz.

Note that onlykubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response tothis:

/cc@RobertKrawitz@pacoxu

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@pacoxu
Copy link
Member

/lgtm
/assign@jsafrane@SergeyKanzhelev

@k8s-ci-robotk8s-ci-robot added the lgtm"Looks good to me", indicates that a PR is ready to be merged. labelNov 6, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1c3afed7c899a32ce1541099a5dbd7a67e2354d0

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mattcarymattcaryAwaiting requested review from mattcary

@mauriciopoppemauriciopoppeAwaiting requested review from mauriciopoppe

@pacoxupacoxuAwaiting requested review from pacoxu

Labels

cncf-cla: yesIndicates the PR's author has signed the CNCF CLA.kind/bugCategorizes issue or PR as related to a bug.lgtm"Looks good to me", indicates that a PR is ready to be merged.needs-priorityIndicates a PR lacks a `priority/foo` label and requires one.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.release-noteDenotes a PR that will be considered when it comes time to generate release notes.sig/storageCategorizes an issue or PR as relevant to SIG Storage.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Concurrent map write error when creating a pod with empty volumes

5 participants

@carlory@k8s-ci-robot@pacoxu@jsafrane@SergeyKanzhelev
[8]ページ先頭
©2009-2025 Movatter.jp