Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

kubeadm: add --allow-deprecated-api to 'config validate'#135148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
neolit123 wants to merge1 commit intokubernetes:master
base:master
Choose a base branch
Loading
fromneolit123:1.35-add-deprecated-api-flag-to-config-validate

Conversation

@neolit123
Copy link
Member

What type of PR is this?

/kind bug feature

What this PR does / why we need it:

The command can have this additional flag so that a warning is printed or not printed when a deprecated API is validated.

Additionally, this commit fixes missing UpgradeConfiguration validation and strict errors. By default we call:
documentMapToUpgradeConfiguration(gvkmap, false, false, false)

so there is no change in behavior outside of
'config migrate/validate'.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: added the flag --allow-deprecated-api to 'kubeadm config validate'. By default the command will print a warning for a deprecated API unless the flag is passed. Additionally, added missing support for v1beta4 UpgradeConfiguration to 'kubeadm config migrate|validate' commands.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

The command can have this additional flag so that a warningis printed or not printed when a deprecated API is validated.Additionally, this commit fixes missing UpgradeConfigurationvalidation and strict errors. By default we call:  documentMapToUpgradeConfiguration(gvkmap, false, false, false)so there is no change in behavior outside of'config migrate/validate'.
@k8s-ci-robotk8s-ci-robot added release-noteDenotes a PR that will be considered when it comes time to generate release notes. kind/bugCategorizes issue or PR as related to a bug. size/MDenotes a PR that changes 30-99 lines, ignoring generated files. kind/featureCategorizes issue or PR as related to a new feature. cncf-cla: yesIndicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. needs-priorityIndicates a PR lacks a `priority/foo` label and requires one. labelsNov 5, 2025
@k8s-ci-robotk8s-ci-robot added area/kubeadm sig/cluster-lifecycleCategorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sigIndicates an issue or PR lacks a `sig/foo` label and requires one. labelsNov 5, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR isAPPROVED

This pull-request has been approved by:neolit123

The full list of commands accepted by this bot can be foundhere.

The pull request process is describedhere

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing/approve in a comment
Approvers can cancel approval by writing/approve cancel in a comment

@k8s-ci-robotk8s-ci-robot added the approvedIndicates a PR has been approved by an approver from all required OWNERS files. labelNov 5, 2025
@neolit123
Copy link
MemberAuthor

/triage accepted
/hold

@k8s-ci-robotk8s-ci-robot added do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command. triage/acceptedIndicates an issue or PR is ready to be actively worked on. and removed needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one. labelsNov 5, 2025
@neolit123
Copy link
MemberAuthor

@neolit123
Copy link
MemberAuthor

neolit123 commentedNov 5, 2025•
edited
Loading

context:
https://kubernetes.slack.com/archives/C09QZ4DQB/p1762360781997679?thread_ts=1762293757.641709&cid=C09QZ4DQB
having this can help 'kind', but i guess it's not critical to merge before CF. if someone has bandwidth PTAL for review.

@neolit123
Copy link
MemberAuthor

/retest

2 similar comments
@neolit123
Copy link
MemberAuthor

/retest

@HirazawaUi
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commentedNov 6, 2025•
edited
Loading

@neolit123: The following testfailed, say/retest to rerun all failed tests or/retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
pull-kubernetes-e2e-kinde566515linktrue/test pull-kubernetes-e2e-kind

Full PR test history.Your PR dashboard. Please help us cut down on flakes bylinking to anopen issue when you hit one in your PR.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. I understand the commands that are listedhere.

@HirazawaUi
Copy link
Contributor

Do we expect to include this PR in the v1.35 cycle?

@neolit123
Copy link
MemberAuthor

Do we expect to include this PR in the v1.35 cycle?

in terms of the new flag, the slack conversation continued and i don't think this is critical for 1.35:
#135148 (comment)
because the command already does whatkind needs. erroring out on strict unmarshall errors for both v1beta3 and v1beta4.

the other fix here is an actual bug. without the upgradeconfig changes we cannot convert v1beta4 -> v1, which is a blocker for the v1 release, but that's not planned yet.

so IMO, it's better to put this on hold until 1.36, unless folks think otherwise.

HirazawaUi reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@carlorycarloryAwaiting requested review from carlory

@HirazawaUiHirazawaUiAwaiting requested review from HirazawaUi

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.area/kubeadmcncf-cla: yesIndicates the PR's author has signed the CNCF CLA.do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command.kind/bugCategorizes issue or PR as related to a bug.kind/featureCategorizes issue or PR as related to a new feature.needs-priorityIndicates a PR lacks a `priority/foo` label and requires one.release-noteDenotes a PR that will be considered when it comes time to generate release notes.sig/cluster-lifecycleCategorizes an issue or PR as relevant to SIG Cluster Lifecycle.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neolit123@k8s-ci-robot@HirazawaUi
[8]ページ先頭
©2009-2025 Movatter.jp