Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support for Groups in Connections File#311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
orlovm wants to merge4 commits intokristijanhusak:master
base:master
Choose a base branch
Loading
fromorlovm:db-groups

Conversation

@orlovm
Copy link

Support for Groups in Connections File

This MR adds support for groups in the connections file andcloses#135.
All changes are fully backward compatible with existing connection files.

New Structure

[    {"name":"this_is_a_group","connections": [            {"url":"postgres://postgres:postgres@localhost:5432/postgres","name":"this is a nested connection"            }        ]    },    {"url":"postgres://postgres:postgres@localhost:5432/users","name":"users"    }]

Implementation Notes

No additional group manipulation commands were implemented.
Grouping is handled naturally by prefixing connection names with the desired group path when using :DBUIAddConnection.
Groups could be renamed and deleted as usual connection.

image

L3v3L reacted with thumbs up emoji
Copy link
Owner

@kristijanhusakkristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR, and sorry for holding this for so long.
Can you rebase from master and fix the conflicts? There were some changes in the rendering logic from the previous PR.

@orlovm
Copy link
Author

Done!
I waited two years for someone to implement this before doing it myself, so waiting for a review is no big deal.
BTW, this is one of my favorite and most used plugins—thanks for it!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@kristijanhusakkristijanhusakAwaiting requested review from kristijanhusak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Groups in connection file?

2 participants

@orlovm@kristijanhusak

[8]ページ先頭

©2009-2025 Movatter.jp