NotificationsYou must be signed in to change notification settings
Fork113
Star1.9k

feat: add database exploring for mongodb#268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

entropitor wants to merge1 commit intokristijanhusak:master

base:master

Choose a base branch

fromentropitor:master

Open

feat: add database exploring for mongodb#268

entropitor wants to merge1 commit intokristijanhusak:masterfromentropitor:master

Conversation

Copy link

entropitor commentedAug 7, 2024

Fixes#104

feat: add database exploring for mongodb

af3f060

kristijanhusak requested changes

Jan 3, 2025

View reviewed changes

Copy link

Owner

kristijanhusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR, and sorry for the late review!

Generally looks good, but we should consider handling connection strings that already have a db name inside, and show results differently.

autoload/db_ui/schemas.vim

		\'requires_stdin':v:true,
		\}

		lets:mongodb_dbs_query='"\n" + db.adminCommand("listDatabases").databases.map(x => x.name).join("\n")'

Copy link

Owner

kristijanhusakJan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We need to consider the case where the database name is defined in the url, for examplemongodb://localhost:27017/my_test_db.
In that situation, we should just show table names.
We already do similar thing for mysql/mariadbhere. We can convert that to a hash map and considermongodb andmongodb+srv as part of that.

I added this myself to see how it looks, and noticed that table names in drawer gotdb. prepended, likedb.users. We can probably solve that in theschemes_tables_query somehow.