Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cassandra Support#215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ViSHNUPrABU wants to merge5 commits intokristijanhusak:master
base:master
Choose a base branch
Loading
fromViSHNUPrABU:master

Conversation

@ViSHNUPrABU
Copy link

@ViSHNUPrABUViSHNUPrABU commentedDec 27, 2023
edited
Loading

I have added Cassandra support and only change in common part is in results_parser in schemas.vim where I trimmed the result and check if it is empty while filtering the array. Before the result is filtered by empty-trim check, so the trim will not be affected to original array. Checkout the pull request fordadbod-completion

Problem:
There is a problem when we connect the db with password in the URL as it shows warning message. So while slicing the output it is improper. Kindly fix that issue.

@kristijanhusak
Copy link
Owner

Before the result is filtered by empty-trim check, so the trim will not be affected to original array

Why do we need to apply trim to the original array? What issues happen if we do not apply the trim?

I'd like to avoid doing double mapping here if not necessary. If we get entries that needs to be trimmed we can do that on another place where we already map out the results.

@ViSHNUPrABU
Copy link
Author

Why do we need to apply trim to the original array? What issues happen if we do not apply the trim?

In Cassandra, the received output has leading and trialing spaces, so the keyspaces and tables are not mapped at all if not trimmed.

I'd like to avoid doing double mapping here if not necessary. If we get entries that needs to be trimmed we can do that on another place where we already map out the results.

We can also iterate the dictionary and trim but trimming while splitting result seems easy for me. We can move the trimming part to another variable below the "mapped" variable.

@kristijanhusak
Copy link
Owner

I checked if there is maybe a faster way to do it but it seems that using map and filter is the most performant.
I think this will be good to go oncetpope/vim-dadbod#148 is merged

ViSHNUPrABU reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ViSHNUPrABU@kristijanhusak@vishnu-prabu-17366

[8]ページ先頭

©2009-2025 Movatter.jp