Commit732416a

fisker

and

ExplodingCabbage

authored

Improve tree shakability (#612)

* Add `sideEffects: false` to `libesm/package.json`* Make tweaks I proposed in convo at#612* Fix build for Unix (and break it again for Windows in the process)* Use `node --eval`* --target es6 for ESM build@fisker points out at#612 (comment) that ESM modules aren't usable by ES5 environments anyway, so targeting ES5 is pointless---------Co-authored-by: Mark Amery <markrobertamery@gmail.com>

1 parent0365f4b commit732416aCopy full SHA for 732416a

File tree

1 file changed

-2

lines changed

package.json

1 file changed

-2

lines changed

`‎package.json‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,8 @@`
`71`	`71`	`"clean":"rm -rf libcsm/ libesm/ dist/ coverage/ .nyc_output/",`
`72`	`72`	`"lint":"yarn eslint",`
`73`	`73`	`"build":"yarn lint && yarn generate-esm && yarn generate-cjs && yarn check-types && yarn run-rollup && yarn run-uglify",`
`74`		`-"generate-cjs":"yarn tsc --module commonjs --outDir libcjs &&echo '{\"type\":\"commonjs\"}' >libcjs/package.json",`
`75`		`-"generate-esm":"yarn tsc --module nodenext --outDir libesm &&echo '{\"type\":\"module\"}' >libesm/package.json",`
	`74`	`+"generate-cjs":"yarn tsc --module commonjs --outDir libcjs &&node --eval\"fs.writeFileSync('libcjs/package.json', JSON.stringify({type:'commonjs',sideEffects:false}))\"",`
	`75`	`+"generate-esm":"yarn tsc --module nodenext --outDir libesm--target es6&&node --eval\"fs.writeFileSync('libesm/package.json', JSON.stringify({type:'module',sideEffects:false}))\"",`
`76`	`76`	`"check-types":"yarn run-tsd && yarn run-attw",`
`77`	`77`	`"test":"nyc yarn _test",`
`78`	`78`	`"_test":"yarn build && cross-env NODE_ENV=test yarn run-mocha",`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit732416a

File tree

1 file changed

1 file changed

`‎package.json‎`

0 commit comments