Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Support setting cookie domain on a per-request basis.#227

Draft
rahulgi wants to merge2 commits intokoajs:master
base:master
Choose a base branch
Loading
fromeverydotorg:master

Conversation

rahulgi
Copy link

This is a proof-of-concept to enable passing a function for thedomain config option to dynamically modify the cookie domain based on the incoming request.

It does so by adding a call to a newmodifyOptsForRequest helper anywherecookies.set is called.

modifyOptsForRequest creates a copy ofopts, checks whether theopts.domain value is a function, and replaces thedomain value with the result of that function if so.

An example of how this might be used:

app.use(session({  domain: (ctx, opts) => {    return ctx.get("origin") || DEFAULT_ORIGIN;  }});

This specifically addresses#188, but it should be easy to extend this PR to support the other cookie config options (likehttpOnly,maxAge, etc.). If this approach looks good and maintainers would be interested in the fix, I'd be happy to update this PR to properly do so - let me know!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@rahulgi

[8]ページ先頭

©2009-2025 Movatter.jp