Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update autocomplete styling#806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
AllanOcelot wants to merge24 commits intokiwiirc:master
base:master
Choose a base branch
Loading
fromAllanOcelot:UPDATE_autocomplete

Conversation

@AllanOcelot
Copy link
Contributor

The styling for the autoComplete component was very outdated compared to the rest of Kiwi.
I've updated the components styling along with all of our current themes.

@ItsOnlyBinary
Copy link
Collaborator

Think you might want to make it a table, as nicks can push the action descriptionSend Message out of alignment

@ItsOnlyBinary
Copy link
Collaborator

ItsOnlyBinary commentedJan 31, 2019•
edited
Loading

I just had a thought remove message user infront of the username the send message is some what misleading as its highlighting them in the channel not sending them a pm.

Maybe it should just be removed and instead show an @ or user icon in front

@AllanOcelot
Copy link
ContributorAuthor

@ItsOnlyBinary - I'm going to rebase this PR and try to rework the autoComplete today

…TE_autocomplete# Conflicts:#static/themes/coffee/theme.css#static/themes/dark/theme.css#static/themes/default/theme.css#static/themes/grayfox/theme.css#static/themes/nightswatch/theme.css#static/themes/osprey/theme.css#static/themes/radioactive/theme.css#static/themes/sky/theme.css
@AllanOcelot
Copy link
ContributorAuthor

I've gone with a new layout idea for the AutoComplete - Something that takes up less time and feels alot more modern. It also stops our alignment issues, please provide feedback here :)

(https://imgur.com/a/jsg1Zmz )

- Added colums (2) on table and (1) on mobile- Better position of the autoComplete component
… open- REMOVED: Colum-Count from the autoComplete on mobile- ANNOYED: Prawnsalad by pointing out Colums were his idea in the first place ;)
@AllanOcelotAllanOcelot added the Needs ReviewThis PR needs a member of the team to review, before being merged into master. labelMar 19, 2019
Copy link
Collaborator

@ItsOnlyBinaryItsOnlyBinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just the unused settings bindings and all looks good to me

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ItsOnlyBinaryItsOnlyBinaryItsOnlyBinary left review comments

@prawnsaladprawnsaladAwaiting requested review from prawnsalad

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs ReviewThis PR needs a member of the team to review, before being merged into master.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AllanOcelot@ItsOnlyBinary
[8]ページ先頭
©2009-2025 Movatter.jp