Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork227
Scroll to start of unread messages when switching buffers#763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
rebased |
src/components/MessageList.vue Outdated
| // Find the message id for unread marker | ||
| for (let i=0; i<this.filteredMessages.length; i++) { | ||
| if (this.shouldShowUnreadMarker(i)) { | ||
| let idx= (i-1>=0)? i-1:0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could do with a quick comment on what this calculation is for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
wish i could remember what its for :(
src/components/MessageList.vue Outdated
| } | ||
| // No unread messages found scroll to bottom | ||
| let forceScroll=this.buffer.setting('force_scroll_to_bottom'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In what case would it ever not want to go to the bottom here? scrollToUnread() must scroll to the unread messages. If there are none available then unread starts at the very bottom
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This for for people who would like to disable the scroll to unread feature (scroll to unread drives me mad on some channels on discord where i only want to see most recent messages)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It sounds like you're mixing up disabling of this feature and skipping to the bottom when there are no unread messages available?
No description provided.