I don't think everyone would want e2e on their kiwi, but why not just make it as a plugin, though we have an e2e plugin called plugin-olmhttps://github.com/kiwiirc/plugin-olm maybe work on that might help to improve it better?! Not that I'm against the idea, but consider if kiwi has this then users of mirc / adiirc must have it too or other clients.

@Shillos Thank you for your feedback on this.

Based on the plugin you mention there, it looks like you are thinking of 'e2e' in the sense of end to end encryption. A clarification: 'e2e' here means end to end tests, not end to end encryption.

We added functional tests that run in the pipeline, using a framework called Cypress, similar to Selenium, etc.

This PR isn't related to encryption.

My mistake then! :-) After you said selenium then I realized what you meant by it. Ok, I looked it up! it's just that you said e3e most people will think just the same as the end to end for the encryption. So what exactly are these tests for? This isn't like CircleCi i guess!

@Green125 Hi! This is awesome - Cypress is something that's been on my radar and wanted to get integrated for a while. I'll be going through this this week and will drop a comment/review. Thank you!

@Shillos Not a worry :)

@prawnsalad thank you!

Firstly, thanks for this. I've taken some time to get to it but I've finally managed to glance over it.

Some points re. integration:

• We use yarn to install kiwi and run scripts, not npm. otherwise different lockfiles will be used
• Cypress test files seem to all use their own linting+prettier which is different than the rest of the project, can they not be sharing the same configs since eslint conf is in the root project folder?
• It's connecting freenode, can we have it setup a quick IRCd locally to speed things up and not spam third party networks? ngircd is a single binary and single config file - it could run in the background.

Some notes on the tests themselves

• I see that it must run user1 and user2 concurrently but I'm not sure what makes it run that way? Since other commands are run sequentially.

• I'm not following how a test such as this one workshttps://github.com/kiwiirc/kiwiirc/pull/1517/files?file-filters%5B%5D=.conf&file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.lock&file-filters%5B%5D=.sh&file-filters%5B%5D=.yml&file-filters%5B%5D=dotfile#diff-c521789533683cd95a429a13b26eed206f013dd5d9004b697c309f8163457253R105
  It's sending a message to user1, but we can't confirm that user1 has received it here. In this test though it looks like it's checking for an error? Or is it just checking that we think we've sent it and it's added to the UI?

What may be easier and will definitely be more reliable in a test setting, is using the kiwi API to simulate incoming IRC traffic. iekiwi.state.getActiveNetwork().ircClient.connection.addReadBuffer(':user1!user@host.com PRIVMSG user2 :Greetings') to simulateuser1 sending a PM touser2. This would also mean that only 1 test instance needs to run.

Some selectors should be more specific, scoped to the components it's looking under. ie.https://github.com/kiwiirc/kiwiirc/pull/1517/files?file-filters%5B%5D=.conf&file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.lock&file-filters%5B%5D=.sh&file-filters%5B%5D=.yml&file-filters%5B%5D=dotfile#diff-fe50c9b85061ba8156472f54025d7b3886aebb43084f3715999b7b8a390b37b1R85 could look under.kiwi-welcome-simple-form

Firstly, thanks for this. I've taken some time to get to it but I've finally managed to glance over it.

Some points re. integration:

• We use yarn to install kiwi and run scripts, not npm. otherwise different lockfiles will be used
• Cypress test files seem to all use their own linting+prettier which is different than the rest of the project, can they not be sharing the same configs since eslint conf is in the root project folder?
• It's connecting freenode, can we have it setup a quick IRCd locally to speed things up and not spam third party networks? ngircd is a single binary and single config file - it could run in the background.

Some notes on the tests themselves

• I see that it must run user1 and user2 concurrently but I'm not sure what makes it run that way? Since other commands are run sequentially.
• I'm not following how a test such as this one workshttps://github.com/kiwiirc/kiwiirc/pull/1517/files?file-filters%5B%5D=.conf&file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.lock&file-filters%5B%5D=.sh&file-filters%5B%5D=.yml&file-filters%5B%5D=dotfile#diff-c521789533683cd95a429a13b26eed206f013dd5d9004b697c309f8163457253R105
  It's sending a message to user1, but we can't confirm that user1 has received it here. In this test though it looks like it's checking for an error? Or is it just checking that we think we've sent it and it's added to the UI?

What may be easier and will definitely be more reliable in a test setting, is using the kiwi API to simulate incoming IRC traffic. iekiwi.state.getActiveNetwork().ircClient.connection.addReadBuffer(':user1!user@host.com PRIVMSG user2 :Greetings') to simulateuser1 sending a PM touser2. This would also mean that only 1 test instance needs to run.

Some selectors should be more specific, scoped to the components it's looking under. ie.https://github.com/kiwiirc/kiwiirc/pull/1517/files?file-filters%5B%5D=.conf&file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.lock&file-filters%5B%5D=.sh&file-filters%5B%5D=.yml&file-filters%5B%5D=dotfile#diff-fe50c9b85061ba8156472f54025d7b3886aebb43084f3715999b7b8a390b37b1R85 could look under.kiwi-welcome-simple-form

Thank you for the excellent and detailed feedback!

I will address the items you listed, push commits to the branch for this PR, and post a message here once that's done.

@Green125 nice, if you want to discuss over IRC (i know youve PMd already...) give me a poke and I'll be glad to

@ItsOnlyBinary Hello, I've spoken with Illmari and I'm looking to take over this PR and complete it. I can get this done and merged. What's the best way to discuss this with you?

@emilymgalore hey, sounds great, you can either discuss here, or poke me on irc.libera,chat #kiwiirc

Either ask@Green125 to add you to their fork so you can continue to push to the same branch, or pull the branch to your fork and create a new pull request