Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork227
Make captcha always show when needed#1473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
src/components/Captcha.vue Outdated
| // If we have a network instance already, send the captcha response | ||
| if (this.network&&this.network.state==='connecting') { | ||
| this.network.ircClient.raw('CAPTCHA', response); | ||
| this.networks.forEach((network)=> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This part seems a little weird. Each network captcha request would have a difference response wouldn't they? So sending the same response to every network would cause them to fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
WIG only uses one captcha key, so it should be fine for multiple networks to validate the same response,
i shall try to find a way to test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
then again i might be totally wrong :(
need to look into this some more
closes#1470