Commit6f05ff6

committed

Fix bug with deriving default key from undefined props.

1 parente5b3853 commit6f05ff6Copy full SHA for 6f05ff6

File tree

+11

-2

lines changed

+11

-2

lines changed

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,9 @@`
`2`	`2`
`3`	`3`	`All notable changes to this project will be documented in this file.`
`4`	`4`
	`5`	`+##3.1.5 - 2023-03-16`
	`6`	`+- Fix bug with deriving default key from undefined props.`
	`7`	`+`
`5`	`8`	`##3.1.4 - 2023-01-16`
`6`	`9`
`7`	`10`	- Support searching by key in`logic.findMounted(123)` and`logic.isMounted('string key')`.

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ export function kea<L extends Logic = Logic>(`
`109`	`109`	`}`
`110`	`110`	`wrapper.find=(keyOrProps?:Record<string,any>\|KeyType)=>{`
`111`	`111`	`constbuiltLogic=`
`112`		`-typeofkeyOrProps==='object'`
	`112`	`+typeofkeyOrProps==='object'\|\|typeofkeyOrProps==='undefined'`
`113`	`113`	`?getCachedBuiltLogicByProps<L>(wrapper,keyOrProps)`
`114`	`114`	`:getCachedBuiltLogicByKey<L>(wrapper,keyOrProps)`
`115`	`115`	`if(builtLogic&&getContext().mount.counter[builtLogic.pathString]>0){`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import{kea,resetContext,getContext}from'../../src'`
	`1`	`+import{kea,resetContext,getContext,path,key}from'../../src'`
`2`	`2`
`3`	`3`	`describe('mount',()=>{`
`4`	`4`	`beforeEach(()=>{`
`@@ -193,4 +193,10 @@ describe('mount', () => {`
`193`	`193`	`expect(logic.isMounted()).toEqual(true)`
`194`	`194`	`})`
`195`	`195`	`})`
	`196`	`+`
	`197`	`+test('can mount logic with default key',()=>{`
	`198`	`+constlogic=kea([path((key)=>['scenes','misc',key]),key(({ id})=>id??'default')])`
	`199`	`+logic.mount()`
	`200`	`+expect(logic.isMounted()).toEqual(true)`
	`201`	`+})`
`196`	`202`	`})`

Comments

(0)