- Notifications
You must be signed in to change notification settings - Fork2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Suggest use StdIn.ReadLine instend of Predef.ReadLine cause Predef.ReadLine has been deprecated#547
Open
zsdz wants to merge1 commit intokanaka:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@zsdz sorry for the very slow followup. I would definitely consider merging this if you changed all the files and also cleaned up the commit to have a better commit summary like "[scala] use StdIn.ReadLine instead of deprecated Predef.readLine" and if you can, add a link in the commit body to a notice of this being deprecated. |
Thanks.But github can't be connected since 2021 from china.I will commit later***@***.***From: Joel MartinDate: 2021-04-22 05:50To: kanaka/malCC: zsdz; MentionSubject: Re: [kanaka/mal] Suggest use StdIn.ReadLine instend of Predef.ReadLine cause Predef.ReadLine has been deprecated (#547)@zsdz sorry for the very slow followup. I would definitely consider merging this if you changed all the files and also cleaned up the commit to have a better commit summary like "[scala] use StdIn.ReadLine instead of deprecated Predef.readLine" and if you can, add a link in the commit body to a notice of this being deprecated.—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
method ReadLine defined in predef has been deprecated since scala 2.11.0
I change the code with StdIn.ReadLine in step0_repl.scala,and it works fine
If this pull will be accepted,I will change other code in the files