- Notifications
You must be signed in to change notification settings - Fork1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(payment-link): alternate text for manual captures#7574
Open
mrudulvajpayee4935 wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Review changes with Changed Files
|
| @@ -319,7 +319,7 @@ function initializeEventListeners(paymentDetails) { | |||
| var payNowButtonText = document.createElement("div"); | |||
| var payNowButtonText = document.getElementById('submit-button-text'); | |||
| if (payNowButtonText) { | |||
| payNowButtonText.textContent = paymentDetails.payment_button_text || translations.payNow; | |||
| payNowButtonText.textContent = paymentDetails.amount==0 ? translations.addPaymentMethod : paymentDetails.payment_button_text || translations.payNow; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Give precedence topaymentDetails.payment_button_text
And use strict check (===) for equality statement, since this is JS ..
Better to use if else for readability, since we have 3 variables involved now
4c46287 tof796402Comparekashif-m approved these changesMar 25, 2025
sahkal approved these changesMar 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Payment links will have
Add Payment Methodas the button text in case of manual captures payments. Payment button text is localised and will have value according to locale used.Additional Changes
Motivation and Context
Payment links created with capture_method: manual - where the intention is to authorize the customer for some non zero amount, and capture the authorized amount at some later point in time. In such scenarios, the text Pay Now is incorrect as the user is not actually paying in that moment.
How did you test it?
Curl:
Checklist
cargo +nightly fmt --allcargo clippy