juspay/hyperswitchPublic

NotificationsYou must be signed in to change notification settings
Fork3.9k
Star22k

feat(payment-link): alternate text for manual captures#7574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

likhinbopanna merged 3 commits intomainfromalternate-text-for-manual-captures

Apr 25, 2025

Merged

feat(payment-link): alternate text for manual captures#7574

likhinbopanna merged 3 commits intomainfromalternate-text-for-manual-captures

Apr 25, 2025

Conversation

Copy link

Contributor

mrudulvajpayee4935 commentedMar 19, 2025•
edited
Loading

Type of Change

Bugfix
New feature
Enhancement
Refactoring
Dependency updates
Documentation
CI/CD

Description

Payment links will haveAdd Payment Method as button text in case merchant send is_setup_mandate_flow astrue in payment_link_config,Authorize Payment in case of manual capture payments andPay Now in automatic captures.
is_setup_mandate_flow field is only used to alter the text in payment button our core flow of setup mandate remains the same i.e setup mandate flow is used only if amount is zero other authorize flow is used in payments core.
Priority given according to below:

Payment button text added while business profile creation.
is_setup_mandate_flow passed in payment_link_config
Zero amount setup mandate flow.
Manual captures payment.
Automatic captures.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

Payment links created with capture_method: manual - where the intention is to authorize the customer for some non zero amount, and capture the authorized amount at some later point in time. In such scenarios, the text Pay Now is incorrect as the user is not actually paying in that moment.

How did you test it?

Curls involved to test the flows:

Automatic captures:

curl --location 'http://localhost:8080/payments' \--header 'Content-Type: application/json' \--header 'Accept: application/json' \--header 'api-key: dev_qTm0pV0gtb4DRMB1eKS5h3EgUvdNvvSADkPjZMXyUY5rvEkvPUMdJBjMq0Y8M7MV' \--data-raw '{    "currency": "EUR",    "amount": 10,    "authentication_type": "three_ds",    "description": "Joseph First Crypto",    "email": "hyperswitch_sdk_demo_id@gmail.com",    "setup_future_usage": "off_session",    "connector_metadata": {        "noon": {            "order_category": "applepay"        }    },    "payment_link": true,    "return_url": "http://127.0.0.1:5500/src/pl_iframe.html",    "payment_link_config": {        "theme": "#14356f",        "logo": "https://logosandtypes.com/wp-content/uploads/2020/08/zurich.svg",        "seller_name": "Zurich Inc.",        "setup_mandate": true    },    "metadata": {        "udf1": "value1",        "new_customer": "true",        "login_date": "2019-09-10T10:11:12Z"    },    "customer_acceptance": null,    "customer_id": "cus_CL6UOh3X35RCzaGNN24t"}'

Manual Captures:

curl --location 'http://localhost:8080/payments' \--header 'Content-Type: application/json' \--header 'Accept: application/json' \--header 'api-key: dev_qTm0pV0gtb4DRMB1eKS5h3EgUvdNvvSADkPjZMXyUY5rvEkvPUMdJBjMq0Y8M7MV' \--data-raw '{    "currency": "EUR",    "amount": 10,    "authentication_type": "three_ds",    "description": "Joseph First Crypto",    "email": "hyperswitch_sdk_demo_id@gmail.com",    "setup_future_usage": "off_session",    "connector_metadata": {        "noon": {            "order_category": "applepay"        }    },    "payment_link": true,    "return_url": "http://127.0.0.1:5500/src/pl_iframe.html",    "payment_link_config": {        "theme": "#14356f",        "logo": "https://logosandtypes.com/wp-content/uploads/2020/08/zurich.svg",        "seller_name": "Zurich Inc."    },    "metadata": {        "udf1": "value1",        "new_customer": "true",        "login_date": "2019-09-10T10:11:12Z"    },    "customer_acceptance": null,    "capture_method": "manual",    "customer_id": "cus_CL6UOh3X35RCzaGNN24t"}'

setup_mandate_flow

curl --location 'http://localhost:8080/payments' \--header 'Content-Type: application/json' \--header 'Accept: application/json' \--header 'api-key: dev_qTm0pV0gtb4DRMB1eKS5h3EgUvdNvvSADkPjZMXyUY5rvEkvPUMdJBjMq0Y8M7MV' \--data-raw '{    "currency": "EUR",    "amount": 10,    "authentication_type": "three_ds",    "description": "Joseph First Crypto",    "email": "hyperswitch_sdk_demo_id@gmail.com",    "setup_future_usage": "off_session",    "connector_metadata": {        "noon": {            "order_category": "applepay"        }    },    "payment_link": true,    "return_url": "http://127.0.0.1:5500/src/pl_iframe.html",    "payment_link_config": {        "theme": "#14356f",        "logo": "https://logosandtypes.com/wp-content/uploads/2020/08/zurich.svg",        "seller_name": "Zurich Inc.",        "is_setup_mandate_flow": true    },    "metadata": {        "udf1": "value1",        "new_customer": "true",        "login_date": "2019-09-10T10:11:12Z"    },    "customer_acceptance": null,    "capture_method": "manual",    "customer_id": "cus_CL6UOh3X35RCzaGNN24t"}'

setup_mandate_flow with zero amount

curl --location 'http://localhost:8080/payments' \--header 'Content-Type: application/json' \--header 'Accept: application/json' \--header 'api-key: dev_iwLbXyltixlkkaaEPH4Sa5HtJtXlDKZ9wOdiGGZV3RTDhgl24aD9lbghKEn9fz88' \--data-raw '{    "currency": "EUR",    "amount": 0,    "setup_future_usage": "off_session",    "authentication_type": "three_ds",    "description": "Joseph First Crypto",    "email": "hyperswitch_sdk_demo_id@gmail.com",    "connector_metadata": {        "noon": {            "order_category": "applepay"        }    },    "payment_link": true,    "return_url": "http://127.0.0.1:5500/src/pl_iframe.html",    "payment_link_config": {        "theme": "#14356f",        "logo": "https://logosandtypes.com/wp-content/uploads/2020/08/zurich.svg",        "seller_name": "Zurich Inc."    },    "metadata": {        "udf1": "value1",        "new_customer": "true",        "login_date": "2019-09-10T10:11:12Z"    },    "customer_acceptance": null,    "customer_id": "cus_CL6UOh3X35RCzaGNN24t"}'

Checklist

I formatted the codecargo +nightly fmt --all
I addressed lints thrown bycargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible

mrudulvajpayee4935 added the Payment Links label

Mar 19, 2025

mrudulvajpayee4935 added this to theFebruary 2025 Release milestone

Mar 19, 2025

mrudulvajpayee4935 self-assigned this

Mar 19, 2025

mrudulvajpayee4935 requested a review froma team as acode owner

March 19, 2025 12:09

Copy link

semanticdiff-combot commentedMar 19, 2025•
edited
Loading

Review changes with

Changed Files

File	Status
crates/router/src/core/payment_link.rs	57% smaller
crates/router/src/core/payment_link/payment_link_initiate/payment_link.js	9% smaller
api-reference-v2/openapi_spec.json	0% smaller
api-reference/openapi_spec.json	0% smaller
crates/api_models/src/admin.rs	0% smaller
crates/api_models/src/payments.rs	0% smaller
crates/diesel_models/src/business_profile.rs	0% smaller
crates/diesel_models/src/payment_intent.rs	0% smaller
crates/hyperswitch_domain_models/src/lib.rs	0% smaller
crates/router/src/core/payment_link/locale.js	0% smaller
crates/router/src/core/payments/transformers.rs	0% smaller
crates/router/src/types/transformers.rs	0% smaller

mrudulvajpayee4935 linked an issue

Mar 19, 2025

that may beclosed by this pull request

Alternate text for Pay Now button for manual captures#7573

Open

kashif-m reviewed

Mar 19, 2025

View reviewed changes

crates/router/src/core/payment_link/payment_link_initiate/payment_link.js OutdatedShow resolvedHide resolved

SanchithHegde modified the milestones:February 2025 Release,March 2025 Release

Mar 21, 2025

mrudulvajpayee4935 force-pushed thealternate-text-for-manual-captures branch from4c46287 tof796402Compare

March 25, 2025 08:02

kashif-m previously approved these changes

Mar 25, 2025

View reviewed changes

sahkal previously approved these changes

Mar 25, 2025

View reviewed changes

Junjun13910 reviewed

Mar 30, 2025

View reviewed changes

crates/router/src/core/payment_link/payment_link_initiate/payment_link.jsShow resolvedHide resolved

SanchithHegde modified the milestones:March 2025 Release,April 2025 Release

Apr 2, 2025

mrudulvajpayee4935 dismissed stale reviews fromsahkal andkashif-m viacaba777

April 24, 2025 08:23

mrudulvajpayee4935 force-pushed thealternate-text-for-manual-captures branch fromf796402 tocaba777Compare

April 24, 2025 08:23

mrudulvajpayee4935 requested a review froma team as acode owner

April 24, 2025 08:23

dynamic payment button text

7f9afb2

mrudulvajpayee4935 force-pushed thealternate-text-for-manual-captures branch fromcaba777 to7f9afb2Compare

April 24, 2025 08:24

hyperswitch-botbot added the M-api-contract-changesMetadata: This PR involves API contract changes label

Apr 24, 2025

sahkal previously approved these changes

Apr 24, 2025

View reviewed changes

kashif-m reviewed

Apr 24, 2025

View reviewed changes

crates/hyperswitch_domain_models/src/lib.rsShow resolvedHide resolved

handle actual zero amount payments

a8b9748

mrudulvajpayee4935 dismissedsahkal’sstale review viaa8b9748

April 24, 2025 18:08

mrudulvajpayee4935 force-pushed thealternate-text-for-manual-captures branch from8d21c90 toa8b9748Compare

April 24, 2025 18:08

hyperswitch-botbot removed the M-api-contract-changesMetadata: This PR involves API contract changes label

Apr 24, 2025

docs(openapi): re-generate OpenAPI specification

951ca83

hyperswitch-botbot added the M-api-contract-changesMetadata: This PR involves API contract changes label

Apr 24, 2025

kashif-m approved these changes

Apr 25, 2025

View reviewed changes

crates/router/src/core/payment_link/payment_link_initiate/payment_link.js

		if (paymentDetails.payment_button_text) {
		payNowButtonText.textContent = paymentDetails.payment_button_text;
		} else if (paymentDetails.is_setup_mandate_flow \|\| (paymentDetails.amount==="0.00" && paymentDetails.setup_future_usage_applied ==="off_session")) {
		payNowButtonText.textContent = translations.addPaymentMethod;