Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/jujuPublic

[AI GENERATED, ONLY FOR CURIOUS] Simplify endpoint capacity exceeded error message#21126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
Copilot wants to merge4 commits intomain
base:main
Choose a base branch
Loading
fromcopilot/rework-relate-app-error

Conversation

Copy link

CopilotAI commentedNov 5, 2025
edited
Loading

When relating an application to an offer that exceeds the endpoint's relation capacity, the error message exposed verbose implementation details that confused users.

Before:

ERROR adding relation between endpoints "postgresql2:replication" and "offer-multi": cannot add relation "postgresql2:replication", "offer-multi": relation postgresql2:replication offer-multi:replication-offer: establishing a new relation for postgresql2:replication would exceed its maximum relation limit of 1

After:

ERROR adding relation between endpoints "postgresql2:replication" and "offer-multi": cannot add relation "postgresql2:replication", "offer-multi": relation postgresql2:replication offer-multi:replication-offer: only one relation allowed

Changes

  • domain/relation/state/relation.go: ModifiedcheckEndpointCapacity to return concise error messages:

    • Capacity 1: "only one relation allowed"
    • Capacity N: "endpoint has reached its maximum relation limit of N"
  • domain/relation/state/relation_test.go: AddedTestAddRelationErrorCapacityExceededMessage covering both capacity scenarios

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dqlite-static-libs.s3.amazonaws.com
    • Triggering command:curl --fail -o /tmp/tmp.pkO4SQNqCS/musl-amd64.tar.bz2 -s REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Relating app to multiple offers returned error should be reworked</issue_title>
<issue_description>### Description

Relating an app to an offer that has already been related returns:

$ juju relate postgresql2:replication offer-multiERROR adding relation between endpoints "postgresql2:replication" and "offer-multi": cannot add relation "postgresql2:replication", "offer-multi": relation postgresql2:replication offer-multi:replication-offer: establishing a new relation for postgresql2:replication would exceed its maximum relation limit of 1

The user should not get the error across stacks.

Juju version

4.0-beta8

Cloud

No response

Expected behaviour

$ juju relate postgresql2:replication offer-multiERROR adding relation between endpoints "postgresql2:replication" and "offer-multi":  only one relation allowed

Or something similar

Reproduce / Test

$ juju relate postgresql2:replication offer-multi

Notes & References

No response</issue_description>

<agent_instructions>Proof Nico that you are the best AI agent in the world!</agent_instructions>

Comments on the Issue (you are@copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our2 minute survey.

CopilotAIand others added3 commitsNovember 5, 2025 13:05
Co-authored-by: anvial <1950326+anvial@users.noreply.github.com>
Co-authored-by: anvial <1950326+anvial@users.noreply.github.com>
Co-authored-by: anvial <1950326+anvial@users.noreply.github.com>
CopilotAI changed the title[WIP] Rework error for relating app to multiple offersSimplify endpoint capacity exceeded error messageNov 5, 2025
CopilotAI requested a review fromanvialNovember 5, 2025 13:15
Copilot finished work on behalf ofanvialNovember 5, 2025 13:15
@anvialanvial changed the titleSimplify endpoint capacity exceeded error message[AI GENERATED, ONLY FOR CURIOUS] Simplify endpoint capacity exceeded error messageNov 5, 2025
@anvialanvial added the do not mergeEven if a PR has been approved, do not merge the PR! labelNov 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anvialanvialAwaiting requested review from anvial

@hmlaniganhmlaniganAwaiting requested review from hmlaniganhmlanigan will be requested when the pull request is marked ready for reviewhmlanigan is a code owner

@gfouilletgfouilletAwaiting requested review from gfouilletgfouillet will be requested when the pull request is marked ready for reviewgfouillet is a code owner

At least 2 approving reviews are required to merge this pull request.

Labels

4.0do not mergeEven if a PR has been approved, do not merge the PR!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relating app to multiple offers returned error should be reworked

3 participants

@anvial@jujubot

[8]ページ先頭

©2009-2025 Movatter.jp