Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Search for an item to compare in context of form#637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
sievlev wants to merge2 commits intojquery-validation:master
base:master
Choose a base branch
Loading
fromsievlev:pull-request-equalsto

Conversation

sievlev
Copy link

No description provided.

@jzaefferer
Copy link
Collaborator

All theequalTo examples use id-selectors, so it doesn't matter where the element is located. Do you have a specific issue this is addressing where the restriction to the form is needed? That would help to come up with unit tests and documentation.

@sievlev
Copy link
Author

It's a very error prone to use id-selectors in a complex administrative web applications with a lot of forms. Risk to create a collision is too high. I'm prefer to use in a such interfaces a more simple selectors by name in context of form.

I will add a unit tests and a documentation in next commits.

@sievlev
Copy link
Author

Another reason to apply my patch is to have a same behavior with 'required' method.

@sievlev
Copy link
Author

ping ;)

@jzaefferer
Copy link
Collaborator

Thanks for the test. The change is reasonable, too. I'm wondering how many people currently use theequalTo method with a target outside of the current form. In that case, this change would break their setup. Both 1.10 and 1.11 each have severe bugs that broke existing sites, so I don't want to add to the pile with something that I can see coming.

Unless you have a better idea, I'll keep this open for some more time, until I can make a cut to a 2.0 release with more backwards incompatible changes.

@staabm
Copy link
Member

Is there still interest in getting this PR landed?

@staabmstaabmforce-pushed themaster branch 2 times, most recently fromd621aab to3861ce2CompareSeptember 26, 2016 14:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@sievlev@jzaefferer@staabm

[8]ページ先頭

©2009-2025 Movatter.jp