Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Search for an item to compare in context of form#637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
All the |
It's a very error prone to use id-selectors in a complex administrative web applications with a lot of forms. Risk to create a collision is too high. I'm prefer to use in a such interfaces a more simple selectors by name in context of form. I will add a unit tests and a documentation in next commits. |
Another reason to apply my patch is to have a same behavior with 'required' method. |
ping ;) |
Thanks for the test. The change is reasonable, too. I'm wondering how many people currently use the Unless you have a better idea, I'll keep this open for some more time, until I can make a cut to a 2.0 release with more backwards incompatible changes. |
Is there still interest in getting this PR landed? |
d621aab
to3861ce2
Compare
No description provided.