Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: Unnecessary aria-describedby (makes #2094 fixable)#2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
eden-jh wants to merge15 commits intojquery-validation:master
base:master
Choose a base branch
Loading
fromeden-jh:unnecessary-aria-describedby

Conversation

eden-jh
Copy link

@eden-jheden-jh commentedNov 16, 2021
edited
Loading

Apologies for the messy commit history. I squashed it (eden-jh@73a70d2) but then it forced me to merge before pushing.

Description

I added anariaDescribedByCleanup option to the validator setting. The default is false just to keep the current behavior (leave the value in place but empty and hide the error elements). I don't feel strongly about that, but it felt safer to make this opt-in, especially because there's a certain amount of customization that needs to happen in order for this to be a problem.

Fixes#2094 (kind of; the examples given in the issue are from unobtrusive, and the default is the current behavior, the setting will have to be updated in unobtrusive.)

Added additional tests for this functionality, plus a demo page.

Groups

aria-describedby is used on all group elements if any of them has an error, and is only removed when all elements in that group are valid. This seemed the most consistent with the current functionality.

eden-jhand others added15 commitsNovember 2, 2021 17:33
Ensure that aria-describedby is removed from all members of a group when all the known errors are resolved
Includes additional unit tests and a demo page
@github-actions
Copy link

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automatically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up.
Thank you for contributing :)

@github-actionsgithub-actionsbot added the staleUsed to mark stale issues labelApr 15, 2022
@bytestreambytestream reopened thisMay 8, 2024
@bytestreambytestream added NEEDS REVIEW and removed staleUsed to mark stale issues labelsMay 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary aria-describedby attribute causes WCAG scans to fail
2 participants
@eden-jh@bytestream

[8]ページ先頭

©2009-2025 Movatter.jp