Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: simplify destroy method#2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Arkni wants to merge1 commit intojquery-validation:master
base:master
Choose a base branch
Loading
fromArkni:destroy-simplify

Conversation

Arkni
Copy link
Member

No description provided.

@staabm
Copy link
Member

Not sure we can do this change, as people might rely on this classnames for css and/or js.

A github code search could give an answer to this question...

@Arkni
Copy link
MemberAuthor

Arkni commentedJun 20, 2018
edited
Loading

I did a search and all I can find is our own source code. I even check the source code ofjquery-validation-unobtrusive which is one of the famous plugins that depend onjQuery Validation. I also checkedwet-boew/wet-boew which heavily use this plugin for validation.

But I guess, it would be best suitable for v2.

/cc@RobJohnston: wdyt about this?

@RobJohnston
Copy link
Contributor

I don't have any great insight, as JavaScript isn't my bailiwick. When I wrote those methods, I was following the pattern.

@Arkni
Copy link
MemberAuthor

Thanks for the input@RobJohnston
@staabm I'll play it safe regarding this and schedule it for v2

staabm reacted with thumbs up emoji

@ArkniArkni added this to the2.0.0 milestoneJun 20, 2018
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@staabmstaabmstaabm approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

3 participants
@Arkni@staabm@RobJohnston

[8]ページ先頭

©2009-2025 Movatter.jp