Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
Core: simplify destroy method#2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Not sure we can do this change, as people might rely on this classnames for css and/or js. A github code search could give an answer to this question... |
Arkni commentedJun 20, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I did a search and all I can find is our own source code. I even check the source code of But I guess, it would be best suitable for v2. /cc@RobJohnston: wdyt about this? |
I don't have any great insight, as JavaScript isn't my bailiwick. When I wrote those methods, I was following the pattern. |
Thanks for the input@RobJohnston |
No description provided.