Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for Stale bot#2176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

Arkni
Copy link
Member

I will install the bots on this repo after we agree on the message of the comments.

Ref#2127

/cc@staabm

@ArkniArkni changed the titleStale no response botsAdd support for Stale and No-response botsJun 4, 2018
This issue has been automatically marked as idle and stale because it hasn't
had any recent activity. It will be automtically closed if no further activity
occurs. If you think this is wrong, or the problem still persists, just pop
a reply in the comments and @staabm or @Arkni will (try!) to follow up.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please dont mention us... the bot will spam us with notifications ;-)

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Haha, I forgot why I put them in there.

I will replace them withone of the maintainers

# Issues with these labels will never be considered stale
exemptLabels:
- bug
- "MERGE ME"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should we add "help wanted" here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

and also "NEEDS REVIEW"?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You're right. I should add those too.

@ArkniArkniforce-pushed thestale-no-response-bots branch 3 times, most recently froma55ea53 to7050cf6CompareJune 4, 2018 10:17
@Arkni
Copy link
MemberAuthor

@staabm Updated per above suggestions

@staabm
Copy link
Member

in case we miss something in the config, does the bot support some kind of rollback, so we dont need to batch-update all issues in case of a mistake?

@Arkni
Copy link
MemberAuthor

Arkni commentedJun 4, 2018•
edited
Loading

As far as I know, none of the two bots support a rollback action.

Theno-response bot only support 3 options, which we already use. As for theStale bot, there are still some usefull options to use. For example,exemptMilestones that can be used to ignore issues or pull requests that are part of a milestone. We can also useonly option to limit the bot to issues only or pull requests (by default, it manage the two).

For more options, seehttps://github.com/probot/stale#usage

@Arkni
Copy link
MemberAuthor

Also, forgot to mention that theno-response bot has a annoying issue when the original poster closed the issue, seeprobot/no-response#16

@staabm
Copy link
Member

staabm commentedJun 4, 2018•
edited
Loading

maybe we should start with the "stale" bot only and see how things go.

the other bot config file could be stored in a separate PR for later merge.

@Arkni
Copy link
MemberAuthor

Sounds good to me. I will update the PR later today.

@ArkniArkniforce-pushed thestale-no-response-bots branch from7050cf6 toa966e9fCompareJune 5, 2018 12:13
@ArkniArkni changed the titleAdd support for Stale and No-response botsAdd support for Stale botJun 5, 2018
@Arkni
Copy link
MemberAuthor

Update per above suggestion. I think we are good to go.

@Arkni
Copy link
MemberAuthor

I broke the PR into two:

@staabm
Copy link
Member

ok cool, thank you.

@staabmstaabm merged commit934822b intojquery-validation:masterJun 5, 2018
@ArkniArkni deleted the stale-no-response-bots branchJune 5, 2018 12:33
@Arkni
Copy link
MemberAuthor

I have sent an installation request tojquery-validation. As you're the one who created this org, only you have the right to accept the request.

@jzaefferer
Copy link
Collaborator

Should the bot apply to all repos, or only this one?

@staabm
Copy link
Member

we don't have "Issues"-tab activated in the other reposes

@jzaefferer
Copy link
Collaborator

I guess you already approved it? I'm not sure based on the email notification and Apps UI...

@staabm
Copy link
Member

yep, I did.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@staabmstaabmstaabm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Arkni@staabm@jzaefferer
[8]ページ先頭
©2009-2025 Movatter.jp