Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Core: Add multiple attribute to email method.#2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
RobJohnston wants to merge2 commits intojquery-validation:master
base:master
Choose a base branch
Loading
fromRobJohnston:1722-email-input-type-and-the-multiple-attribute

Conversation

RobJohnston
Copy link
Contributor

Using@Sven-Mad's method.Fixes#1722.

@stale
Copy link

stalebot commentedJun 5, 2018

This issue/proposal has been automatically marked as idle and stale because it hasn't had any recent activity. It will be automtically closed if no further activity occurs. If you think this is wrong, or the problem still persists, just pop a reply in the comments and one of the maintainers will (try!) to follow up.
Thank you for contributing :)

@stalestalebot added the staleUsed to mark stale issues labelJun 5, 2018
@RobJohnston
Copy link
ContributorAuthor

I think this PR still has merit.

@stalestalebot removed the staleUsed to mark stale issues labelJun 5, 2018
@Arkni
Copy link
Member

Arkni commentedJun 16, 2018
edited
Loading

Hi@RobJohnston,

Sorry for taking so long to review this PR. I only have one concern about this implementation. Thatno_multiple argument will always betrue whether you are setting the rule using inline HTML or in JS.

What I would like to suggest is, we add support for passing an object toemail method in JS like the following:

$("form").validate({rules:{field:{email:true|false|{multiple:true|false}}}});

Theno_multiple parameter will need to be changed toparam (or another convenient name).

@ArkniArkni mentioned this pull requestJul 20, 2018
@RobJohnston
Copy link
ContributorAuthor

RobJohnston commentedFeb 29, 2020
edited
Loading

Hi@Arkni . It's now my time to apologize to you for the delay! I've been away from front-end development for some time. I didn't quite understand your comment when I first read it and not sure if I do now.

From the W3, themultiple attribute is what they call aboolean attribute, but that doesn't mean that it can be set to "true" or "false". It must bemultiple="multiple" or simply justmultiple. To represent a false value, the attribute has to be omitted altogether. Does that change your suggestion where you wrote:

multiple:true|false

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@maysammaysammaysam approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

email input type and the multiple attribute
3 participants
@RobJohnston@Arkni@maysam

[8]ページ先頭

©2009-2025 Movatter.jp