- Notifications
You must be signed in to change notification settings - Fork34
fix(useAtomDevtools): disconnect from redux devtools on unmount#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codesandbox-cibot commentedMar 8, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This pull request is automatically built and testable inCodeSandbox. To see build info of the built libraries, clickhere or the icon next to each commit SHA. Latest deployment of this branch, based on commit07cd8bb:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🎉
| return()=>{ | ||
| (extensionasany).disconnect(); | ||
| unsubscribe?.(); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, this looks like the correct fix. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I misunderstood. Thought it'sconnection.disconnect().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
we need a feature from redux-devtools.
| return()=>{ | ||
| (extensionasany).disconnect(); | ||
| unsubscribe?.(); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I misunderstood. Thought it'sconnection.disconnect().
Uh oh!
There was an error while loading.Please reload this page.
Fixes -pmndrs/jotai#1795 (reply in thread)
Edit: Blocked byreduxjs/redux-devtools#1370