Commitedeb01b

committed

use stepId to validate progress

1 parent17c6661 commitedeb01bCopy full SHA for edeb01b

File tree

+11

-9

lines changed

+11

-9

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@ class Channel implements Channel {`
`22`	`22`	`console.log('RECEIVED:',actionType)`
`23`	`23`	`switch(actionType){`
`24`	`24`	`case'TEST_RUN':`
`25`		`-vscode.commands.executeCommand('coderoad.run_test')`
	`25`	`+`
	`26`	`+vscode.commands.executeCommand('coderoad.run_test',action.payload)`
`26`	`27`	`return`
`27`	`28`	`case'TUTORIAL_CONFIG':`
`28`	`29`	`tutorialConfig(action.payload)`

Lines changed: 8 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,22 +52,26 @@ export const createCommands = ({vscodeExt}: CreateCommandProps) => {`
`52`	`52`
`53`	`53`	`webview.createOrShow(column)`
`54`	`54`	`},`
`55`		`-[COMMANDS.RUN_TEST]:()=>{`
	`55`	`+[COMMANDS.RUN_TEST]:({stepId}:{stepId:string})=>{`
`56`	`56`	`console.log('run test webview',Object.keys(webview))`
`57`	`57`	`runTest({`
`58`	`58`	`onSuccess:()=>{`
`59`	`59`	`console.log('COMMAND TEST_PASS')`
`60`		`-webview.send({type:'TEST_PASS'})`
	`60`	`+webview.send({type:'TEST_PASS',payload:{stepId}})`
`61`	`61`	`vscode.window.showInformationMessage('PASS')`
`62`	`62`	`},`
`63`	`63`	`onFail:()=>{`
`64`	`64`	`console.log('COMMAND TEST_FAIL')`
`65`		`-webview.send({type:'TEST_FAIL'})`
	`65`	`+webview.send({type:'TEST_FAIL',payload:{stepId}})`
`66`	`66`	`vscode.window.showWarningMessage('FAIL')`
`67`	`67`	`},`
	`68`	`+onError:()=>{`
	`69`	`+console.log('COMMAND TEST_ERROR')`
	`70`	`+webview.send({type:'TEST_ERROR',payload:[stepId]})`
	`71`	`+},`
`68`	`72`	`onRun:()=>{`
`69`	`73`	`console.log('COMMAND TEST_RUN')`
`70`		`-webview.send({type:'TEST_RUN'})`
	`74`	`+webview.send({type:'TEST_RUN',payload:{stepId}})`
`71`	`75`	`}`
`72`	`76`	`})`
`73`	`77`	`},`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -104,13 +104,10 @@ export default {`
`104`	`104`	`//@ts-ignore`
`105`	`105`	`updateStepProgress:assign({`
`106`	`106`	`progress:(context:CR.MachineContext,event:CR.MachineEvent):CR.Progress=>{`
`107`		`-`
`108`	`107`	`// update progress by tracking completed`
`109`	`108`	`constcurrentProgress:CR.Progress=context.progress`
`110`	`109`
`111`		`-// TODO: should use event id, to verify not multiple successes jumping one`
`112`		`-// const stepId = event.payload.stepId`
`113`		`-const{stepId}=context.position`
	`110`	`+const{stepId}=event.payload`
`114`	`111`
`115`	`112`	`currentProgress.steps[stepId]=true`
`116`	`113`

Comments

(0)