Commit38688f2

authored and

committed

Fix the remove method for the MinHeap (trekhleb#50)

* Fix LinkedList* Fix the prepend method for the LinkedList* Fix the remove method for the MinHeap

1 parent9f83862 commit38688f2Copy full SHA for 38688f2

File tree

+23

-1

lines changed

+23

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -141,8 +141,8 @@ export default class MinHeap {`
`141`	`141`	`*/`
`142`	`142`	`remove(item,customFindingComparator){`
`143`	`143`	`// Find number of items to remove.`
`144`		`-constnumberOfItemsToRemove=this.find(item).length;`
`145`	`144`	`constcustomComparator=customFindingComparator\|\|this.compare;`
	`145`	`+constnumberOfItemsToRemove=this.find(item,customComparator).length;`
`146`	`146`
`147`	`147`	`for(letiteration=0;iteration<numberOfItemsToRemove;iteration+=1){`
`148`	`148`	`// We need to find item index to remove each time after removal since`

Lines changed: 22 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`importMinHeapfrom'../MinHeap';`
	`2`	`+importComparatorfrom'../../../utils/comparator/Comparator';`
`2`	`3`
`3`	`4`	`describe('MinHeap',()=>{`
`4`	`5`	`it('should create an empty min heap',()=>{`
`@@ -147,4 +148,25 @@ describe('MinHeap', () => {`
`147`	`148`	`expect(minHeap.remove(3).toString()).toEqual('4');`
`148`	`149`	`expect(minHeap.remove(4).toString()).toEqual('');`
`149`	`150`	`});`
	`151`	`+`
	`152`	`+it('should be possible to remove items from heap with custom finding comparator',()=>{`
	`153`	`+constminHeap=newMinHeap();`
	`154`	`+minHeap.add('dddd');`
	`155`	`+minHeap.add('ccc');`
	`156`	`+minHeap.add('bb');`
	`157`	`+minHeap.add('a');`
	`158`	`+`
	`159`	`+expect(minHeap.toString()).toBe('a,bb,ccc,dddd');`
	`160`	`+`
	`161`	`+constcomparator=newComparator((a,b)=>{`
	`162`	`+if(a.length===b.length){`
	`163`	`+return0;`
	`164`	`+}`
	`165`	`+`
	`166`	`+returna.length<b.length ?-1 :1;`
	`167`	`+});`
	`168`	`+`
	`169`	`+minHeap.remove('hey',comparator);`
	`170`	`+expect(minHeap.toString()).toBe('a,bb,dddd');`
	`171`	`+});`
`150`	`172`	`});`

Comments

(0)