Commit2c007f4

authored

Fix GitHub ListPullRequestReviews (#118)

1 parent5004344 commit2c007f4Copy full SHA for 2c007f4

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ func (client *GitHubClient) ListPullRequestReviewComments(ctx context.Context, o`
`473`	`473`	`iferr!=nil {`
`474`	`474`	`returnnil,err`
`475`	`475`	`}`
`476`		`-commentsList,_,err:=ghClient.PullRequests.ListReviews(ctx,owner,repository,pullRequestID,nil)`
	`476`	`+commentsList,_,err:=ghClient.PullRequests.ListComments(ctx,owner,repository,pullRequestID,nil)`
`477`	`477`	`iferr!=nil {`
`478`	`478`	`return []CommentInfo{},err`
`479`	`479`	`}`
`@@ -482,7 +482,7 @@ func (client *GitHubClient) ListPullRequestReviewComments(ctx context.Context, o`
`482`	`482`	`commentsInfoList=append(commentsInfoList,CommentInfo{`
`483`	`483`	`ID:comment.GetID(),`
`484`	`484`	`Content:comment.GetBody(),`
`485`		`-Created:comment.GetSubmittedAt(),`
	`485`	`+Created:comment.GetCreatedAt(),`
`486`	`486`	`})`
`487`	`487`	`}`
`488`	`488`	`returncommentsInfoList,nil`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -314,14 +314,16 @@ func TestGitHubClient_ListPullRequestReviewComments(t *testing.T) {`
`314`	`314`	`ctx:=context.Background()`
`315`	`315`	`id:=int64(1)`
`316`	`316`	`body:="test"`
`317`		`-client,cleanUp:=createServerAndClient(t,vcsutils.GitHub,false, []*github.PullRequestReview{{ID:&id,Body:&body}},"/repos/jfrog/repo-1/pulls/1/reviews",createGitHubHandler)`
	`317`	`+created:=time.Date(1970,time.January,1,0,0,0,0,time.UTC)`
	`318`	`+client,cleanUp:=createServerAndClient(t,vcsutils.GitHub,false, []*github.PullRequestComment{{ID:&id,Body:&body,CreatedAt:&created}},"/repos/jfrog/repo-1/pulls/1/comments",createGitHubHandler)`
`318`	`319`	`defercleanUp()`
`319`	`320`
`320`	`321`	`commentInfo,err:=client.ListPullRequestReviewComments(ctx,owner,repo1,1)`
`321`	`322`	`assert.NoError(t,err)`
`322`	`323`	`assert.Len(t,commentInfo,1)`
`323`	`324`	`assert.Equal(t,id,commentInfo[0].ID)`
`324`	`325`	`assert.Equal(t,body,commentInfo[0].Content)`
	`326`	`+assert.Equal(t,created,commentInfo[0].Created)`
`325`	`327`
`326`	`328`	`commentInfo,err=createBadGitHubClient(t).ListPullRequestReviewComments(ctx,owner,repo1,1)`
`327`	`329`	`assert.Nil(t,commentInfo)`

Comments

(0)