- Notifications
You must be signed in to change notification settings - Fork687
The skipping of null values during array processing has been removed#5241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
happy-boy-maker wants to merge1 commit intojerryscript-project:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
zherczeg commentedJul 22, 2025
Was the old code an optimization, which is not working anymore? |
Author
happy-boy-maker commentedJul 23, 2025
Apart from code format errors, no new issues have been introduced in ci. The deleted code seems to skip whenever an empty value is encountered during the array processing, without any further purpose. |
inconsistent with the mainstream js engine behavior, has been removedJerryScript-DCO-1.0-Signed-off-by: tangbin 2387440390@qq.com
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This patchfixes#5026
Signevior of skipping null values during array processing, which was inconsistent with the mainstream js engine behavior, has been removed.
JerryScript-DCO-1.0-Signed-off-by: tangbin2387440390@qq.com