Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Multiline mode of anchors ^ $, flag "m"#421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
peruibeloko wants to merge5 commits intojavascript-tutorial:master
base:master
Choose a base branch
Loading
fromperuibeloko:09/05

Conversation

@peruibeloko
Copy link
Contributor

No description provided.

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@peruibeloko, could you evaluate the review I did?

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@peruibeloko
Copy link
ContributorAuthor

/done

Copy link
Member

@nazarepiedadynazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is ready to be applied.

@nazarepiedady
Copy link
Member

@danilolmc,@jonnathan-ls, could you help to review this pull request and approve it if it is okay?

Copy link
Contributor

@danilolmcdanilolmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Droped just a single comment, not a big deal!

The PR LGTM!

@peruibeloko
Copy link
ContributorAuthor

@nazarepiedady Implemented the change, we're able to merge now!

danilolmc reacted with rocket emoji

@nazarepiedady
Copy link
Member

@peruibeloko, I need one person to approve the updates, this person does not need necessarily to be a maintainer, a regular contributor serves.

@nazarepiedady
Copy link
Member

@danilolmc, do you have time to approve these updates?

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you approve these updates?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@nazarepiedadynazarepiedadynazarepiedady approved these changes

@odsantosodsantosAwaiting requested review from odsantos

@jonnathan-lsjonnathan-lsAwaiting requested review from jonnathan-ls

+1 more reviewer

@danilolmcdanilolmcdanilolmc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@peruibeloko@javascript-translate-bot@nazarepiedady@danilolmc
[8]ページ先頭
©2009-2025 Movatter.jp