Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

JavaScript Animations#136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
karlasamantha wants to merge9 commits intojavascript-tutorial:master
base:master
Choose a base branch
Loading
fromkarlasamantha:javascript-animations

Conversation

@karlasamantha
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commentedMay 20, 2020•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@wnleao
Copy link
Contributor

Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers!

@karlasamantha
Copy link
Author

Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers!

Hey, yeah. I'm addressing feedback now. My linter changed the code, fixing that :)

@karlasamantha
Copy link
Author

/done

@javascript-translate-botjavascript-translate-bot requested a review froma teamMay 26, 2020 03:46
@karlasamanthakarlasamantha requested review fromwnleao and removed request fora teamMay 26, 2020 03:46
@odsantos
Copy link
Contributor

Hi@karlasamantha would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you.

karlasamantha reacted with thumbs up emoji

@odsantos
Copy link
Contributor

Hi@karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you.

@karlasamantha
Copy link
Author

Hi@karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you.

Hi@odsantos , sorry for the delay! I'll try to fix the conflicts today!

@karlasamantha
Copy link
Author

/done

@javascript-translate-botjavascript-translate-bot requested a review froma teamMay 25, 2021 21:17
@karlasamantha
Copy link
Author

/done

@odsantos
Copy link
Contributor

Hi@karlasamantha , thank you.

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@karlasamantha ,

The article review is still missing, hopefully to another time.
Please, feel free to leave a note on something you may not agree.

Thank you.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

Copy link
Contributor

@odsantosodsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hi@karlasamantha ,

Here is the whole review.
Please, feel free to leave a note where you might not agree.

Thank you,
Osvaldo.

karlasamantha reacted with thumbs up emoji
@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos
Copy link
Contributor

Hello@karlasamantha the English article was updated and this PR now has some conflicts. The changes are small, though. Thank you.
Osvaldo.

karlasamantha reacted with thumbs up emoji

@karlasamanthakarlasamantha requested review fromodsantos andwnleao and removed request forodsantos andwnleaoJanuary 26, 2023 21:16
@karlasamantha
Copy link
Author

/done

@nazarepiedady
Copy link
Member

@odsantos,@jonnathan-ls,@peruibeloko, what do you recommend colleagues to be done in this pull request?

@nazarepiedady
Copy link
Member

@karlasamantha, are you available to update and apply the changes requested?

@karlasamantha
Copy link
Author

@karlasamantha, are you available to update and apply the changes requested?

@nazarepiedady sure, but I don't see any pending changes requested. Am I missing something here?

@nazarepiedady
Copy link
Member

@karlasamantha, I would like to invite you to compare the original English content to the Portuguese content translated by you to see if there are any updates needed or sentences that need to be applied.

I also invite you to check if the reviews did by@odsantos are observed or resolved.

@nazarepiedady
Copy link
Member

@jonnathan-ls, do you have time to review and handle this pull request?

@nazarepiedady
Copy link
Member

@peruibeloko, do you have some time to deal with this pull request?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@odsantosodsantosodsantos requested changes

@wnleaownleaoAwaiting requested review from wnleao

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@karlasamantha@CLAassistant@javascript-translate-bot@wnleao@odsantos@nazarepiedady
[8]ページ先頭
©2009-2025 Movatter.jp