Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix Generator Seed Consistency Test#3873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
LorenzoBloedow wants to merge1 commit intojavascript-tutorial:master
base:master
Choose a base branch
Loading
fromLorenzoBloedow:patch-1

Conversation

LorenzoBloedow
Copy link

If you use a static seed in your code, all tests will pass, because technically the seed is the same, however, the input changed so it shouldn't be the same.

Example of a static seed:
Screenshot 2025-09-06 at 7 25 12 AM

And here's the actual seed being used:
Screenshot 2025-09-06 at 7 25 34 AM

With the current code, both solutions will pass even if the input changes.

@javascript-translate-botjavascript-translate-bot added the review neededReview needed, please approve or request changes labelSep 6, 2025
@CLAassistant
Copy link

CLAassistant commentedSep 6, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

@smith558smith558 self-assigned thisSep 26, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR fixes a test case for pseudo-random generators to ensure proper validation of seed consistency. The test was previously insufficient as it only verified that generators with the same seed produce identical outputs, but failed to test that generators with different seeds produce different outputs.

  • Adds generators with different seeds to verify they produce different outputs
  • Includes assertion to ensure generators with different seeds don't produce identical results

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

@smith558smith558

Labels
review neededReview needed, please approve or request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@LorenzoBloedow@CLAassistant@smith558@javascript-translate-bot

[8]ページ先頭

©2009-2025 Movatter.jp