- Notifications
You must be signed in to change notification settings - Fork4k
Fix Generator Seed Consistency Test#3873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
CLAassistant commentedSep 6, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR fixes a test case for pseudo-random generators to ensure proper validation of seed consistency. The test was previously insufficient as it only verified that generators with the same seed produce identical outputs, but failed to test that generators with different seeds produce different outputs.
- Adds generators with different seeds to verify they produce different outputs
- Includes assertion to ensure generators with different seeds don't produce identical results
Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.
If you use a static seed in your code, all tests will pass, because technically the seed is the same, however, the input changed so it shouldn't be the same.
Example of a static seed:

And here's the actual seed being used:

With the current code, both solutions will pass even if the input changes.