- Notifications
You must be signed in to change notification settings - Fork653
Develop#15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
jds wants to merge22 commits intojamesqquick:developChoose a base branch fromjds:develop
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Open
Develop#15
Changes fromall commits
Commits
Show all changes
22 commits Select commitHold shift + click to select a range
f9f9b15
Adding a Youtube Playlist
thedamiandf9ea21
Video youtube Playlist of James' amazing videos
thedamian12c2394
Updated ReadMe
jamesqquickfa9af0b
Updated Read Me again
jamesqquickacb701e
Got rid of exclamation
jamesqquickc0cb8eb
Merge branch 'master' of https://github.com/jamesqquick/Build-A-Quiz-…
jamesqquick92a5b3d
Merge pull request #1 from bocajs:master
jamesqquickae4c09a
Fixed minor issues.
krishna16sharmaafdf52f
Merge pull request #4 from krishna16sharma/new_branch
jamesqquickc409aeb
Revert "Fixed minor issues."
jamesqquick91c5022
Merge pull request #5 from jamesqquick/revert-4-new_branch
jamesqquickbc235d4
#7 ISSUE RESOLVED
JayantDwivedif5dc509
Update Readme.md
lolyparty0fd212e
Using real values for score instead of dummy data
jamesqquick2082d9e
rmeoved color from folder name
jamesqquick70a7115
Merge pull request #10 from lolyparty/patch-1
jamesqquick4b66bcd
Merge branch 'master' of https://github.com/jamesqquick/Build-A-Quiz-…
jamesqquick63d7363
Updated random index of answer to be in all spots
jamesqquickd792edc
Removed console.logs
jamesqquickf0f54b1
Update ReadMe.md
jdse4ffcbc
Updated Read Me again
jdsc27e597
Update ReadMe.md
jdsFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
37 changes: 18 additions & 19 deletions10. Fetch Questions from Local JSON File/end.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,29 @@ | ||
const username = document.getElementById('username'); | ||
const saveScoreBtn = document.getElementById('saveScoreBtn'); | ||
const finalScore = document.getElementById('finalScore'); | ||
const mostRecentScore = localStorage.getItem('mostRecentScore'); | ||
const highScores = JSON.parse(localStorage.getItem('highScores')) || []; | ||
const MAX_HIGH_SCORES = 5; | ||
finalScore.innerText = mostRecentScore; | ||
username.addEventListener('keyup', () => { | ||
saveScoreBtn.disabled = !username.value; | ||
}); | ||
saveHighScore = (e) => { | ||
e.preventDefault(); | ||
const score = { | ||
score: mostRecentScore, | ||
name: username.value, | ||
}; | ||
highScores.push(score); | ||
highScores.sort((a, b) => b.score - a.score); | ||
highScores.splice(5); | ||
localStorage.setItem('highScores', JSON.stringify(highScores)); | ||
window.location.assign('/'); | ||
}; |
117 changes: 58 additions & 59 deletions10. Fetch Questions from Local JSON File/game.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
37 changes: 18 additions & 19 deletions11. Fetch API Questions from Open Trivia API/end.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,29 @@ | ||
const username = document.getElementById('username'); | ||
const saveScoreBtn = document.getElementById('saveScoreBtn'); | ||
const finalScore = document.getElementById('finalScore'); | ||
const mostRecentScore = localStorage.getItem('mostRecentScore'); | ||
const highScores = JSON.parse(localStorage.getItem('highScores')) || []; | ||
const MAX_HIGH_SCORES = 5; | ||
finalScore.innerText = mostRecentScore; | ||
username.addEventListener('keyup', () => { | ||
saveScoreBtn.disabled = !username.value; | ||
}); | ||
saveHighScore = (e) => { | ||
e.preventDefault(); | ||
const score = { | ||
score: mostRecentScore, | ||
name: username.value, | ||
}; | ||
highScores.push(score); | ||
highScores.sort((a, b) => b.score - a.score); | ||
highScores.splice(5); | ||
localStorage.setItem('highScores', JSON.stringify(highScores)); | ||
window.location.assign('/'); | ||
}; |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.