Commitc067a34

authored

fix:GetEuclidGCD(0, 0) is0 (TheAlgorithms#1621)

1 parent0e0cf98 commitc067a34Copy full SHA for c067a34

File tree

+18

-9

lines changed

+18

-9

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ export function GetEuclidGCD(a, b) {`
`8`	`8`	`if(typeofa!=='number'\|\|typeofb!=='number'){`
`9`	`9`	`thrownewTypeError('Arguments must be numbers')`
`10`	`10`	`}`
`11`		`-if(a===0&&b===0)returnundefined// infinitely many numbers divide 0`
`12`	`11`	`a=Math.abs(a)`
`13`	`12`	`b=Math.abs(b)`
`14`	`13`	`while(b!==0){`

Lines changed: 18 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,12 +1,22 @@`
`1`	`1`	`import{GetEuclidGCD}from'../GetEuclidGCD'`
`2`	`2`
`3`		`-functiontestEuclidGCD(n,m,expected){`
`4`		`-test('Testing on '+n+' and '+m+'!',()=>{`
`5`		`-expect(GetEuclidGCD(n,m)).toBe(expected)`
	`3`	`+describe('GetEuclidGCD',()=>{`
	`4`	`+it.each([`
	`5`	`+[5,20,5],`
	`6`	`+[109,902,1],`
	`7`	`+[290,780,10],`
	`8`	`+[104,156,52],`
	`9`	`+[0,100,100],`
	`10`	`+[-5,50,5],`
	`11`	`+[0,0,0],`
	`12`	`+[1,1234567,1]`
	`13`	`+])('returns correct result for %i and %j',(inputA,inputB,expected)=>{`
	`14`	`+expect(GetEuclidGCD(inputA,inputB)).toBe(expected)`
	`15`	`+expect(GetEuclidGCD(inputB,inputA)).toBe(expected)`
`6`	`16`	`})`
`7`		`-}`
`8`	`17`
`9`		`-testEuclidGCD(5,20,5)`
`10`		`-testEuclidGCD(109,902,1)`
`11`		`-testEuclidGCD(290,780,10)`
`12`		`-testEuclidGCD(104,156,52)`
	`18`	`+it('should throw when any of the inputs is not a number',()=>{`
	`19`	`+expect(()=>GetEuclidGCD('1',2)).toThrowError()`
	`20`	`+expect(()=>GetEuclidGCD(1,'2')).toThrowError()`
	`21`	`+})`
	`22`	`+})`

Comments

(0)