Commit0e0cf98

authored

fix: cleanupCoPrimeCheck (TheAlgorithms#1609)

1 parentfb0a99c commit0e0cf98Copy full SHA for 0e0cf98

File tree

+31

-2

lines changed

+31

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -28,13 +28,13 @@ const GetEuclidGCD = (arg1, arg2) => {`
`28`	`28`	`constCoPrimeCheck=(firstNumber,secondNumber)=>{`
`29`	`29`	`// firstly, check that input is a number or not.`
`30`	`30`	`if(typeoffirstNumber!=='number'\|\|typeofsecondNumber!=='number'){`
`31`		`-returnnewTypeError('Argument is not a number.')`
	`31`	`+thrownewTypeError('Argument is not a number.')`
`32`	`32`	`}`
`33`	`33`	`/*`
`34`	`34`	`This is the most efficient algorithm for checking co-primes`
`35`	`35`	`if the GCD of both the numbers is 1 that means they are co-primes.`
`36`	`36`	`*/`
`37`		`-returnGetEuclidGCD(firstNumber,secondNumber)===1`
	`37`	`+returnGetEuclidGCD(Math.abs(firstNumber),Math.abs(secondNumber))===1`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`export{CoPrimeCheck}`

Lines changed: 29 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,29 @@`
	`1`	`+import{CoPrimeCheck}from'../CoPrimeCheck'`
	`2`	`+`
	`3`	`+describe('CoPrimeCheck',()=>{`
	`4`	`+it.each([`
	`5`	`+[1,1],`
	`6`	`+[1,2],`
	`7`	`+[1,3],`
	`8`	`+[1,7],`
	`9`	`+[20,21],`
	`10`	`+[5,7],`
	`11`	`+[-5,-7]`
	`12`	`+])('returns true for %j and %i',(inputA,inputB)=>{`
	`13`	`+expect(CoPrimeCheck(inputA,inputB)).toBe(true)`
	`14`	`+expect(CoPrimeCheck(inputB,inputA)).toBe(true)`
	`15`	`+})`
	`16`	`+`
	`17`	`+it.each([`
	`18`	`+[5,15],`
	`19`	`+[131719,172329]`
	`20`	`+])('returns false for %j and %i',(inputA,inputB)=>{`
	`21`	`+expect(CoPrimeCheck(inputA,inputB)).toBe(false)`
	`22`	`+expect(CoPrimeCheck(inputB,inputA)).toBe(false)`
	`23`	`+})`
	`24`	`+`
	`25`	`+it('should throw when any of the inputs is not a number',()=>{`
	`26`	`+expect(()=>CoPrimeCheck('1',2)).toThrowError()`
	`27`	`+expect(()=>CoPrimeCheck(1,'2')).toThrowError()`
	`28`	`+})`
	`29`	`+})`

Comments

(0)