Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MIA-Crystal Meneses#326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
shecancode wants to merge1 commit intoironhack-labs:masterfromshecancode:master

Conversation

shecancode
Copy link

No description provided.

for(var i = 0; i < words.length; i++) {
if(words[i].length > length) {
var length = words[i].length;
Longest = words[i];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't capitalize a variable name. You capitalized "Longest".

};

function averageNumbers (numbers) {
var Average = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't capitalize a variable name. You capitalized "Average".

return total;
};

function averageNumbers (numbers) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Your "averageNumbers" function did not work for me when I tried it. Here is one approach you could have done:

// Calculate the AveragefunctionaverageNumbers(array){if(array.length===0){returnundefined;}console.log(sumArray(array),array.length);returnsumArray(array)/array.length;}varnumbersAvg=[2,6,9,10,7,4,1,9];varaverage=averageNumbers(numbersAvg);console.log(average);

@ianizaguirre
Copy link

Try to apply this feedback on your next project.
If you have any questions on my feedback, just send me a message on Slack.
Aside from that, good job and keep up the good work! 😁

Kind Regards,
Ian Izaguirre | Ironhack TA

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ianizaguirreianizaguirreianizaguirre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@shecancode@ianizaguirre

[8]ページ先頭

©2009-2025 Movatter.jp